Regression testing for keyword replacement #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahmed-Ghanam
requested review from
SandGrainOne,
hggutvik,
HenningNormann and
tba76
test/k6/src/config.js
Outdated
| } | ||
|
|
||
| const subscriptionKey = __ENV.subscriptionKey || null; | ||
| if (!subscriptionKey) { |
There was a problem hiding this comment.
This if assumes that subscription key is provided in all cases. This isn't true. We can keep the if, but would need to update all workflow files as well. Subscription key is currently added only when running the orders_email.js file.
There was a problem hiding this comment.
This conditional statement is removed.
|
| -e env=*** ` | ||
| -e orgNoRecipient=*** ` | ||
| -e resourceId=*** ` | ||
| podman compose run k6 run /src/tests/orders_org_no.js \ |
There was a problem hiding this comment.
When it comes to ` vs \ . It depends on what type of console you use. If you use command prompt, powershell or bash. I don't remember which is which. Now that you have changed it maybe write down as a comment which shell the command is made for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement regression testing to ensure that keywords in notifications are correctly replaced with the appropriate values.
Related Issue(s)
Verification
Documentation