Remove extra label and fix test

Altinn · Jan 22, 2025 · 594a238 · 594a238
1 parent e844f92
commit 594a238
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 24 deletions.
diff --git a/...nents/config/componentSpecificContent/Summary2/Override/OverrideFields/EmptyTextField.tsx b/...nents/config/componentSpecificContent/Summary2/Override/OverrideFields/EmptyTextField.tsx
@@ -1,12 +1,7 @@
 import React, { type ChangeEvent } from 'react';
 import classes from './EmptyTextField.module.css';
 import type { Summary2OverrideConfig } from 'app-shared/types/ComponentSpecificConfig';
-import {
-  StudioAlert,
-  StudioLabelAsParagraph,
-  StudioProperty,
-  StudioTextfield,
-} from '@studio/components';
+import { StudioAlert, StudioProperty, StudioTextfield } from '@studio/components';
 import { useTranslation } from 'react-i18next';
 
 type EmptyTextFieldProps = {
@@ -38,19 +33,15 @@ export const EmptyTextField = ({ onChange, override }: EmptyTextFieldProps) => {
   }
 
   return (
-    <>
-      <StudioLabelAsParagraph>
-        {t('ux_editor.component_properties.summary.override.empty_field_text')}
-      </StudioLabelAsParagraph>
-      <StudioTextfield
-        autoFocus={true}
-        onBlur={() => setOpen(false)}
-        onKeyDown={({ key }) => key === 'Enter' && setOpen(false)}
-        value={override.emptyFieldText}
-        onChange={(event: ChangeEvent<HTMLInputElement>) =>
-          onChange({ ...override, emptyFieldText: event.target.value })
-        }
-      />
-    </>
+    <StudioTextfield
+      label={t('ux_editor.component_properties.summary.override.empty_field_text')}
+      autoFocus={true}
+      onBlur={() => setOpen(false)}
+      onKeyDown={({ key }) => key === 'Enter' && setOpen(false)}
+      value={override.emptyFieldText}
+      onChange={(event: ChangeEvent<HTMLInputElement>) =>
+        onChange({ ...override, emptyFieldText: event.target.value })
+      }
+    />
   );
 };
diff --git a/...rc/components/config/componentSpecificContent/Summary2/Override/Summary2Override.test.tsx b/...rc/components/config/componentSpecificContent/Summary2/Override/Summary2Override.test.tsx
@@ -322,13 +322,13 @@ describe('Summary2Override', () => {
     await userEvent.click(overrideCollapsedButton(1));
     const emptyFieldText = 'asdf;ljr%';
     const textFieldButton = screen.getByRole('button', {
-      name: textMock('ux_editor.component_properties.summary.override.empty_field_text'),
+      name: /ux_editor.component_properties.summary.override.empty_field_text/i,
     });
     await user.click(textFieldButton);
     await user.type(
-      screen.getByLabelText(
-        textMock('ux_editor.component_properties.summary.override.empty_field_text'),
-      ),
+      screen.getByRole('textbox', {
+        name: /ux_editor.component_properties.summary.override.empty_field_text/i,
+      }),
       emptyFieldText,
     );
     await waitFor(() =>