-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing header size causes error message #13673
Labels
added-to-sprint
kind/bug
Used when there is a defect / something is not working as it should.
team/studio-domain2
Comments
This was referenced Oct 3, 2024
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
added-to-sprint
kind/bug
Used when there is a defect / something is not working as it should.
team/studio-domain2
Description of the bug
Changing the header size of a header component causes an error message in the app/preview.
Screen.Recording.2024-10-01.at.09.12.08.mov
Steps To Reproduce
See video.
Additional Information
This seems to be caused by the use of the
enum
restriction in the json schema for the component.We are assuming that the type of the enum content is
string
, but that is actually a false assumption. In this case the type isnumber
.It is unfortunate that the json schema does not contain the explicit type in the cases where enum is used - this would make it much clearer for us what type we are working with. In our JSONSchema conversion script, we assume that the type for a property with enums is
string
, but this is not correct.We need to:
string
ornumber
type based on that.EditNumberValue
component to act like theEditStringValue
component when there is an enum set present (i.e. render a select rather than an input field).The text was updated successfully, but these errors were encountered: