Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing header size causes error message #13673

Closed
nkylstad opened this issue Oct 1, 2024 · 0 comments · Fixed by #13694
Closed

Changing header size causes error message #13673

nkylstad opened this issue Oct 1, 2024 · 0 comments · Fixed by #13694
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. team/studio-domain2

Comments

@nkylstad
Copy link
Member

nkylstad commented Oct 1, 2024

Description of the bug

Changing the header size of a header component causes an error message in the app/preview.

Screen.Recording.2024-10-01.at.09.12.08.mov

Steps To Reproduce

See video.

Additional Information

This seems to be caused by the use of the enum restriction in the json schema for the component.
We are assuming that the type of the enum content is string, but that is actually a false assumption. In this case the type is number.
It is unfortunate that the json schema does not contain the explicit type in the cases where enum is used - this would make it much clearer for us what type we are working with. In our JSONSchema conversion script, we assume that the type for a property with enums is string, but this is not correct.

We need to:

  • update the script, to check the value of the first item of the enum array, and set either string or number type based on that.
  • Update the EditNumberValue component to act like the EditStringValue component when there is an enum set present (i.e. render a select rather than an input field).
@nkylstad nkylstad added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Oct 1, 2024
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Oct 1, 2024
@ErlingHauan ErlingHauan self-assigned this Oct 1, 2024
@ErlingHauan ErlingHauan moved this from 👷 In Progress to ⚠️ Blocked in Team Studio Oct 4, 2024
@ErlingHauan ErlingHauan removed their assignment Oct 4, 2024
@ErlingHauan ErlingHauan self-assigned this Oct 4, 2024
@ErlingHauan ErlingHauan linked a pull request Oct 4, 2024 that will close this issue
3 tasks
@ErlingHauan ErlingHauan removed a link to a pull request Oct 4, 2024
3 tasks
@ErlingHauan ErlingHauan moved this from ⚠️ Blocked to 👷 In Progress in Team Studio Oct 7, 2024
@ErlingHauan ErlingHauan moved this from 👷 In Progress to 🔎 Review in Team Studio Oct 16, 2024
@ErlingHauan ErlingHauan moved this from 🔎 Review to 🧪 Test in Team Studio Oct 16, 2024
@github-project-automation github-project-automation bot moved this from 🧪 Test to Documentation in Team Studio Oct 17, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. team/studio-domain2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants