-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error when changing Group heading level #13692
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13692 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 1574 1574
Lines 21276 21280 +4
Branches 2541 2543 +2
=======================================
+ Hits 20088 20092 +4
Misses 943 943
Partials 245 245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK in dev 😄
Description
This PR fixes the error when changing
headingLevel
in aGroup
component.string
tonumber
inGroup.schema.v1.json
component.ts
. If the type is not given for a component propery in the schema, the code will now check the type of the first element of the enum, and either renderEditStringValue
orEditNumberValue
based on the element's type.EditNumberValue
now accepts an enum value, similar toEditStringValue
. If an enum is present, it will render a native select instead of an input field.EditNumberValue
andEditStringValue
.groupingIndicator
property enum.Note that this fix will no longer work the next time the JSON schema component script is run, because it will replace
"type": "number"
with"type": "string"
. The PR that fixes the script is here. Made this a separate PR so that we can get the fix into prod as soon as possible.Related Issue(s)
Videos
Before
heading-level-before.mp4
After
heading-level-after.mp4
Verification