Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update labeler.yml #13625

Merged
merged 5 commits into from
Oct 4, 2024
Merged

chore: Update labeler.yml #13625

merged 5 commits into from
Oct 4, 2024

Conversation

nkylstad
Copy link
Member

Description

Remove outdated labels
Add missing area labels

@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Sep 24, 2024
@nkylstad
Copy link
Member Author

PR does not require testing, as it is run in the PR checks.

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

Some suggestions, not sure if they are relevant:

  • should we also add the labels backend/frontend for changes in the backend/frontend folders? 🤔
  • ui-editor is a term that seems to be used only in the labels. I wonder if we should find an English translation closer to utforming, or maybe use the folder name ux-editor 🤷‍♂️

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (85a8c66) to head (9baa9bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13625   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files        1560     1560           
  Lines       21176    21176           
  Branches     2529     2529           
=======================================
  Hits        19986    19986           
  Misses        946      946           
  Partials      244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad
Copy link
Member Author

Nice work! 🚀

Some suggestions, not sure if they are relevant:

  • should we also add the labels backend/frontend for changes in the backend/frontend folders? 🤔

Sure, that might be relevant wrt who should do reviews etc. Will update!

  • ui-editor is a term that seems to be used only in the labels. I wonder if we should find an English translation closer to utforming, or maybe use the folder name ux-editor 🤷‍♂️

Yep, although ui-editor is probably more descriptive of what the editor actually is. I'll post a discussion on our slack and we can decide what to use!

@nkylstad nkylstad enabled auto-merge (squash) October 4, 2024 12:04
@nkylstad nkylstad added the skip-manual-testing PRs that do not need to be tested manually label Oct 4, 2024
@nkylstad nkylstad merged commit 4a84e3b into main Oct 4, 2024
9 checks passed
@nkylstad nkylstad deleted the chore/update-pr-labeler branch October 4, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants