-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unique header to app preview #13626
Conversation
…s they are shared
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13626 +/- ##
=======================================
Coverage 94.41% 94.42%
=======================================
Files 1574 1580 +6
Lines 21276 21328 +52
Branches 2541 2545 +4
=======================================
+ Hits 20088 20139 +51
Misses 943 943
- Partials 245 246 +1 ☔ View full report in Codecov by Sentry. |
Thank you! |
…tinn/altinn-studio into feat-Add-Unique-header-to-app-preview
…er-to-app-preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK in dev ✅ It works really well, impressive work! 🤩
One thing I noticed, the link to open the repository is missing from the menu. It’s not a big issue though, as the preview page probably needs a general update anyway 🤷♂️
BEFORE (in production) | AFTER (in dev) |
---|---|
![]() |
![]() |
I also had to update your PR with the latest version to test it in dev, but now the typechecking fails. Is this something you can check?
Thank you @mlqn 😄 The one you say is missing is removed on purpose 😄 |
Description
app-review
Related Issue(s)
Verification