Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unique header to app preview #13626

Merged
merged 55 commits into from
Oct 4, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 24, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 24, 2024
@wrt95 wrt95 changed the title Feat add unique header to app preview feat: add unique header to app preview Sep 24, 2024
@wrt95 wrt95 added the frontend label Sep 24, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (939464c) to head (5ae2399).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
frontend/app-preview/test/mocks.tsx 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13626   +/-   ##
=======================================
  Coverage   94.41%   94.42%           
=======================================
  Files        1574     1580    +6     
  Lines       21276    21328   +52     
  Branches     2541     2545    +4     
=======================================
+ Hits        20088    20139   +51     
  Misses        943      943           
- Partials      245      246    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95
Copy link
Contributor Author

wrt95 commented Oct 2, 2024

Great job! I have a few minor comments for you to consider. I noticed that some parts of the files you’ve changed could use a bit more attention, but we can address that in a separate PR. It’s not directly related to what you’re trying to achieve here. 😊

Keep up the good work! 👏

Thank you!
I totally agree. There are a lot of code that needs some attention in App-Preview, both inside the files, but also the structure of the files in the folders. However, I believe that is to be done in another issue yes 😄

@wrt95
Copy link
Contributor Author

wrt95 commented Oct 2, 2024

Moved to block because of this PR.

@wrt95 wrt95 removed their assignment Oct 3, 2024
@github-actions github-actions bot added the area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. label Oct 4, 2024
@mlqn mlqn self-assigned this Oct 4, 2024
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK in dev ✅ It works really well, impressive work! 🤩
One thing I noticed, the link to open the repository is missing from the menu. It’s not a big issue though, as the preview page probably needs a general update anyway 🤷‍♂️

BEFORE (in production) AFTER (in dev)
before after

I also had to update your PR with the latest version to test it in dev, but now the typechecking fails. Is this something you can check?

@mlqn mlqn assigned wrt95 and unassigned mlqn Oct 4, 2024
@wrt95
Copy link
Contributor Author

wrt95 commented Oct 4, 2024

Tested OK in dev ✅ It works really well, impressive work! 🤩 One thing I noticed, the link to open the repository is missing from the menu. It’s not a big issue though, as the preview page probably needs a general update anyway 🤷‍♂️

BEFORE (in production) AFTER (in dev)
before after
I also had to update your PR with the latest version to test it in dev, but now the typechecking fails. Is this something you can check?

Thank you @mlqn 😄 The one you say is missing is removed on purpose 😄
I'll check it, thanks!

@wrt95 wrt95 merged commit 59e2843 into main Oct 4, 2024
9 checks passed
@wrt95 wrt95 deleted the feat-Add-Unique-header-to-app-preview branch October 4, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants