Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing the z-index bug on data model page #13757

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 10, 2024

Description

  • Adding higher z-index to make sure the popover opens up above the header

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (f3053c6) to head (6d07155).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13757   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files        1605     1605           
  Lines       21536    21537    +1     
  Branches     2542     2542           
=======================================
+ Hits        20355    20356    +1     
  Misses        938      938           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Oct 10, 2024
@framitdavid
Copy link
Collaborator

Tested OK. I let the Github action approve this PR as well, since I did both testing and review.

@framitdavid framitdavid removed the skip-manual-testing PRs that do not need to be tested manually label Oct 10, 2024
@framitdavid framitdavid merged commit c198a8d into main Oct 10, 2024
11 checks passed
@framitdavid framitdavid deleted the fix--change-z-index-for-popover-datamodel-page branch October 10, 2024 09:14
@wrt95 wrt95 self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants