-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add StudioSearch component #14348
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeg ser at det er gjort på denne måten enkelte andre steder, men for å følge fasademønsteret, bør vi egentlig lage en egen komponent rundt designsystemkomponenten. Da kan vi også sette size='sm'
som standard og ta i bruk WithoutAsChild
på prop-typen.
Vi har et søkefelt på dashbordet også. Hvis det ikke er for mye jobb, kan du legge den til der i tillegg? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14348 +/- ##
=======================================
Coverage 95.58% 95.59%
=======================================
Files 1869 1871 +2
Lines 24237 24247 +10
Branches 2786 2787 +1
=======================================
+ Hits 23167 23178 +11
Misses 814 814
+ Partials 256 255 -1 ☔ View full report in Codecov by Sentry. |
frontend/libs/studio-components/src/components/StudioSearch/StudioSearch.test.tsx
Outdated
Show resolved
Hide resolved
50c0a82
to
2679d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Var litt rask med å godkjenne denne. Se kommentar.
frontend/libs/studio-components/src/components/StudioSearch/StudioSearch.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioSearch/StudioSearch.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioSearch/StudioSearch.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioSearch/StudioSearch.test.tsx
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioSearch/StudioSearch.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flott!
Description
StudioSearch
component.Dashboard:
nt on dashboard.
Text-editor:
CodeLists in content library:
Related Issue(s)
Verification