Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove eid-logger service #14643

Merged
merged 4 commits into from
Feb 12, 2025
Merged

feat: remove eid-logger service #14643

merged 4 commits into from
Feb 12, 2025

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Feb 12, 2025

  • remove eid logger service
  • remove eid logger code from designer

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Chores

    • Removed legacy automation workflows and container orchestration configurations.
    • Cleaned up outdated build and deployment settings, including related operational documentation.
  • Refactor

    • Streamlined internal event notification by eliminating redundant logging components and simplifying deployment processes.
  • Tests

    • Updated test scenarios to align with the consolidated event handling flow.

Copy link
Contributor

coderabbitai bot commented Feb 12, 2025

📝 Walkthrough

Walkthrough

This pull request removes a set of files and code related to the Eid-logger functionality. It deletes GitHub Actions workflows used for deployment and pull request builds; removes backend components including event handlers, events, service methods, and HTTP client registrations for Eid logging; and eliminates all files associated with the standalone Eidlogger application, including Docker, Maven, configuration, source, and test files.

Changes

Files Change Summary
.github/workflows/deploy-eid-logger.yaml,
.github/workflows/eid-logger-pr-build.yaml
Removed CI/CD workflow files that defined deployment and PR build pipelines for the Eid-Logger application.
backend/src/Designer/EventHandlers/.../AppDeployedEidLoggerHandler.cs,
backend/src/Designer/Events/AppDeployedEvent.cs,
backend/src/Designer/Services/Implementation/DeploymentService.cs,
backend/src/Designer/TypedHttpClients/EidLogger/*.cs,
backend/src/Designer/TypedHttpClients/TypedHttpClientRegistration.cs,
backend/tests/.../DeploymentServiceTest.cs
Removed backend classes, events, methods, and interfaces for handling deployment events and logging via Eid logger, and updated tests to reflect the removal of event publishing logic.
eidlogger/.dockerignore,
eidlogger/.gitignore,
eidlogger/.mvn/wrapper/maven-wrapper.properties,
eidlogger/Dockerfile,
eidlogger/README.md,
eidlogger/compose.yaml,
eidlogger/mvnw*,
eidlogger/pom.xml,
eidlogger/settings.xml.template,
eidlogger/src/...,
eidlogger/src/test/...
Deleted all project files associated with the Eidlogger application, including its Docker, Maven, configuration, source code, and tests.

Suggested labels

added-to-sprint

Suggested reviewers

  • github-actions
  • framitdavid

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61475dd and b9de422.

📒 Files selected for processing (10)
  • charts/eid-logger-config/Chart.yaml (0 hunks)
  • charts/eid-logger-config/templates/helm-release.yaml (0 hunks)
  • charts/eid-logger-config/values.yaml (0 hunks)
  • charts/eid-logger/.helmignore (0 hunks)
  • charts/eid-logger/Chart.yaml (0 hunks)
  • charts/eid-logger/templates/NOTES.txt (0 hunks)
  • charts/eid-logger/templates/_helpers.tpl (0 hunks)
  • charts/eid-logger/templates/deployment.yaml (0 hunks)
  • charts/eid-logger/templates/service.yaml (0 hunks)
  • charts/eid-logger/values.yaml (0 hunks)
💤 Files with no reviewable changes (10)
  • charts/eid-logger/templates/service.yaml
  • charts/eid-logger-config/templates/helm-release.yaml
  • charts/eid-logger-config/values.yaml
  • charts/eid-logger/.helmignore
  • charts/eid-logger/templates/deployment.yaml
  • charts/eid-logger/templates/NOTES.txt
  • charts/eid-logger-config/Chart.yaml
  • charts/eid-logger/Chart.yaml
  • charts/eid-logger/templates/_helpers.tpl
  • charts/eid-logger/values.yaml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Build environment and run e2e test
  • GitHub Check: Run dotnet build and test (macos-latest)
  • GitHub Check: Run dotnet build and test (windows-latest)
  • GitHub Check: Run dotnet build and test (ubuntu-latest)
  • GitHub Check: Run integration tests against actual gitea and db
  • GitHub Check: Analyze

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes backend labels Feb 12, 2025
@mirkoSekulic mirkoSekulic added the skip-manual-testing PRs that do not need to be tested manually label Feb 12, 2025
@mirkoSekulic mirkoSekulic merged commit a5839e1 into main Feb 12, 2025
16 checks passed
@mirkoSekulic mirkoSekulic deleted the feat/remove-eid-logger branch February 12, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. backend quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete current eid-logger service and realted code from studio repo
2 participants