Skip to content

fix(autocomplete): return early if selected is set as empty string #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeidahmed merged 1 commit into from
Jan 9, 2026
Merged

fix(autocomplete): return early if selected is set as empty string #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

- The popover now uses the Dialog API behind the scenes

### Fixed

- Return early if `selected` is set as an empty string

## [0.7.2] - 2025-07-04

### Changed
Expand Down
2 changes: 1 addition & 1 deletion app/components/impulse/select_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def initialize(object_name, method_name, choices = [], selected: nil, **system_a
private

def value
return if @selected.nil?
return if @selected.blank?
return @selected.map { |value| find_option(value) }.compact if multiple?
find_option(@selected)
end
Expand Down
2 changes: 2 additions & 0 deletions test/components/select_component_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ class SelectComponentTest < ApplicationTest
render_inline(Impulse::SelectComponent.new(:user, :fruit_id, ["Apple", "Guava"], selected: "Invalid"))
render_inline(Impulse::SelectComponent.new(:user, :fruit_id, ["Apple", "Guava"], selected: ["", "Apple"], multiple: true))
render_inline(Impulse::SelectComponent.new(:user, :fruit_id, ["Apple", "Guava"], selected: ["Invalid", "Apple"], multiple: true))
render_inline(Impulse::SelectComponent.new(:user, :fruit_id, ["Apple", "Guava"], selected: "", multiple: true))
render_inline(Impulse::SelectComponent.new(:user, :fruit_id, ["Apple", "Guava"], selected: nil, multiple: true))
end
end

Expand Down