Skip to content

fix: popover toggle fn #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeidahmed merged 1 commit into from
Jan 9, 2026
Merged

fix: popover toggle fn #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/impulse/popover_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class PopoverComponent < ApplicationComponent
system_args[:data] = merge_attributes(
system_args[:data],
target: "awc-popover.button",
action: "click->awc-popover#handleToggle"
action: "click->awc-popover#toggle"
)

Impulse::BaseRenderer.new(**system_args)
Expand Down
2 changes: 1 addition & 1 deletion docs/js-api/popover.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ await popover.hide();
Shows/hides the popover.

```js
popover.toggle();
await popover.toggle();
```

### `reposition`
Expand Down
12 changes: 4 additions & 8 deletions src/elements/popover/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ export default class AwcPopoverElement extends ImpulseElement {
this.hide();
}

async handleToggle() {
/**
* Shows/hides the popover.
*/
async toggle() {
if (this.open) {
this.emit('hide');
await this.hide();
Expand All @@ -86,13 +89,6 @@ export default class AwcPopoverElement extends ImpulseElement {
}
}

/**
* Shows/hides the popover.
*/
toggle() {
this.panel.togglePopover();
}

/**
* Shows the popover.
*/
Expand Down