Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waiver filtering update #301

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Waiver filtering update #301

merged 1 commit into from
Oct 28, 2024

Conversation

AleksandrMolchagin
Copy link
Contributor

@AleksandrMolchagin AleksandrMolchagin commented Oct 28, 2024 •
edited
Loading

#298

  • Changes Implemented:

    1. Fix "ValidFrom" and "ValidTo": Ensure that "ValidFrom" and "ValidTo" fields are corrected, as they were previously swapped.
    2. Move Archive Filtering: Move the filtering based on the Archive status from the server logic to the SOQL query itself.
    3. Add Filtering Condition: Add a condition Waiver_Active_End__c >= TODAY in the SOQL query to filter out waivers that haven't met the required timelines.
    4. Handle Missing Waivers: If no waiver is found, return a 404 HTTP status code with the message: "No current waiver found".

  • Examples:

    • Successful Call:
image
  • No Waivers Found:
image

@AleksandrMolchagin
Waiver filtering update
ea7e495 
- Fix "ValidFrom" and "ValidFrom" (they were swapped)
- Move filtering based on the Archive from the server to SOQL query
- Add condition "Waiver_Active_End__c >= TODAY" to filter waivers that are not achieved on time
- If waiver not found, throw 404 error + return message "No current waiver found"
@AleksandrMolchagin AleksandrMolchagin merged commit f1caae4 into sandbox Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CritiqalPete CritiqalPete CritiqalPete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleksandrMolchagin @CritiqalPete