Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running DSO-API unittests against schematools #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DonQueso89
Copy link
Contributor

This PR adds tools for testing schematools against DSO.

The main idea is that we have a Dockerfile which is used locally (thru docker compose) and in an Github Action, to test schematools against the latest DSO (defined to be the tip of master). Since DSO is only compatible with >= python 3.11, we only run these itegration tests for mentioned python version. The compose file has been updated and modernized a bit to act as an executable for testing.

The Github action DSO-test is triggered for all tag push events, including major version releases. But since we usually release packages "manually", a tag push to master is actually too late. It is at the discretion of the devs to make sure that no minor/patch version that breaks DSO is released.

WARNING: DSO is currently not compatible with the newest version of schematools, so merging this will "break" master.

Dockerfile Show resolved Hide resolved
Copy link
Contributor

@jjmurre jjmurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants