Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modern pre-commit config and v6.0 changelog #555

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

vdboor
Copy link
Contributor

@vdboor vdboor commented Jul 9, 2024

This applies black 2024 syntax changes, and introduces ruff. This does a much better job than flake8/isort at detecting code issues. All except the complexity are addressed.

@vdboor vdboor force-pushed the diederik/new-pre-commit branch 2 times, most recently from 26ed6f1 to d09a217 Compare July 9, 2024 07:08
vdboor added 6 commits July 9, 2024 09:16
* requests timeout
* date.today() as argument!
* open() without close()

Minor:

* assert -> raise
* exception "from <cause>"
* type -> isinstance
* combine if-statements
* Django model method ordering
* noqa changes for security checks
* string line lengths
@vdboor vdboor force-pushed the diederik/new-pre-commit branch from d09a217 to 5cd96bf Compare July 9, 2024 07:17
@vdboor vdboor force-pushed the diederik/new-pre-commit branch from 5cd96bf to 7f05ecb Compare July 9, 2024 07:39
Copy link
Contributor

@barrydaniels-nl barrydaniels-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdboor vdboor merged commit 1f6d2be into master Jul 10, 2024
6 checks passed
@vdboor vdboor deleted the diederik/new-pre-commit branch July 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants