Fix schema permission apply and add sequence support.
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… funciton call The only difference is not passing a paremter (defaulting to None).
This allows passing table-type so sequence permissions can also be assigned later. Fix passing auth-permissions to through/nested tables. The nested table permissions were redefined by looping over the full tables, which didn't receive the field.auth data but exposed dataset auth instead. Also there is no need to define auth on their fields if the full table has auth set.
This should fix pg_dump on our databases, which insists on reading the sequences too.
vdboor
changed the title
schema permission apply.schema permission apply and add sequence support.
MaguellSandifort
approved these changes
Oct 1, 2024
|
Gecheckt, in de praktijk had dit alleen effect op |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
get_all_dataset_scopes()walked twice over nested/through tables, and gave it the dataset permissions too (instead of the field permissions). This was visible when refactoring the code, and unit tests confirmed. Hence the list of generated GRANT statements is now included in the tests.