Fixed list iterator

Amulet-Team · Jul 12, 2024 · 15eaa01 · 15eaa01
1 parent 27e8047
commit 15eaa01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/amulet_nbt/cpp/tag/list.cpp b/src/amulet_nbt/cpp/tag/list.cpp
@@ -29,7 +29,9 @@ namespace Amulet {
 
     ListTagIterator::ListTagIterator(Amulet::ListTagPtr tag, size_t start, std::ptrdiff_t step): tag(tag), index(start), step(step) {};
     Amulet::TagNode ListTagIterator::next() {
-        return Amulet::ListTag_get_node<size_t>(*tag, index++);
+        auto node = Amulet::ListTag_get_node<size_t>(*tag, index);
+        index += step;
+        return node;
     }
     bool ListTagIterator::has_next(){
         return index >= 0 && index < ListTag_size(*tag);

diff --git a/src/amulet_nbt/pybind/tag/py_list_tag.cpp b/src/amulet_nbt/pybind/tag/py_list_tag.cpp
@@ -337,7 +337,7 @@ void init_list(py::module& m) {
         ListTag.def(
             "__reversed__",
             [](const Amulet::ListTagWrapper& self) {
-                return Amulet::ListTagIterator(self.tag, ListTag_size(*self.tag), -1);
+                return Amulet::ListTagIterator(self.tag, ListTag_size(*self.tag) - 1, -1);
             }
         );
         ListTag.def(