Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor storage #76

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Refactor storage #76

merged 6 commits into from
Jul 26, 2024

Commits on Jul 18, 2024

  1. Prototype a native class structure

    @gentlegiantJGC
    gentlegiantJGC committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9f3178c View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Refactored NBT storage 

    Storing the NBT tags as native types seemed like a good idea on the C++ side but it made it difficult to integrate with Python.
The NBT tags are now their own classes so a wrapper class is not needed.
    @gentlegiantJGC
    gentlegiantJGC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ba2a4df View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Removed wrapper class and refactored 

    Replaced variant.index switches with variant::visit and holds_alternative.
    @gentlegiantJGC
    gentlegiantJGC committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    20c0bcf View commit details
    Browse the repository at this point in the history

  2. Added missing typename

    @gentlegiantJGC
    gentlegiantJGC committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c81533a View commit details
    Browse the repository at this point in the history

  3. Fix duplicate template parameter

    @gentlegiantJGC
    gentlegiantJGC committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    72b9e0d View commit details
    Browse the repository at this point in the history

  4. Refactor numerical

    @gentlegiantJGC
    gentlegiantJGC committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    55f007c View commit details
    Browse the repository at this point in the history