Open
Conversation
Crosshair drawing is broken when videoAr != displayAr
I'm not sure about that scale_factor, i don't know how to test that
with a "good enough" implementation
The preview window would change in width, when the video was being zoomed. Possibly, because on windows, zooming only calls UpdateSize once, but on linux, it gets called multiple, like 8 times. Rounding fixed it.
I'm not entirely sure, that this is how it's supposed to be added. This requires editing the already existing hotkey.json file (shows path in log, if it exists). Should this also be added to hotkey.cpp?
This reverts commit 3d525d9. The default hotkey is not required. People can just add a custom one from the hotkey settings if they want this.
Do this by partially reverting the changes to UpdateSize in favor of just multiplying by videoZoomValue *after* setting all the window sizes.
It's probably stable enough at this point, and hiding it behind an option just creates more confusion than it prevents.
AkarinVS
force-pushed
the
mod
branch
5 times, most recently
from
7e7951f to
91b6b58
Compare
AkarinVS
force-pushed
the
mod
branch
4 times, most recently
from
4967811 to
7e1cc63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New:
Video - Reset video panKnown issues:
Changes from: