BUGFIX: single thread approach #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A really old edit pkv made to switch from multithreading to single threading created a few bugs because each thread originally maintained it's own client list and each "device" assumed it had a unique thread. This should be a quick and dirty fix where each device now maintains its own client list, a bit redundant given the one in the global thread. Hopefully this also resolves #147, I'm assuming the crash was the result of the error handler originally stopping its own thread (the bug being now it stops the only thread).
Andersama
force-pushed
the
Andersama-singlethread-patch-1
branch
from
9504cb4 to
162c9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A really old edit pkv made to switch from multithreading to single threading created a few bugs because each thread originally maintained it's own client list and each "device" assumed it had a unique thread.
This should be a quick and dirty fix where each device now maintains its own client list, a bit redundant given the one in the global thread.
Hopefully this also resolves #147, I'm assuming the crash was the result of the error handler originally stopping its own thread (the bug being now it stops the only thread).