Terminal in non-TTY mode caused fatal error on connect #23

AndiDittrich · Dec 17, 2016 · 4e5de35 · 4e5de35
1 parent 3a624f9
commit 4e5de35
Show file tree

Hide file tree

Showing 23 changed files with 8 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,6 @@
+### 2.0.3 ###
+Bugfix: Terminal in **non-TTY** mode caused fatal error on connect - thanks to [stephanMettler on GitHub](https://github.com/AndiDittrich/NodeMCU-Tool/issues/23) #23
+
 ### 2.0.2 ###
 Bugfix: Upload command failed because of API changes in NodeMCU Firmware **v1.5.4** - thanks to [curioussavage on GitHub](https://github.com/AndiDittrich/NodeMCU-Tool/issues/22) ##2
 Bugfix: Fix crash when trying to upload a folder - thanks to [sakisds on GitHub](https://github.com/AndiDittrich/NodeMCU-Tool/pull/20) #20 

diff --git a/CONTRIBUTE.md b/CONTRIBUTE.md
diff --git a/LICENSE.md b/LICENSE.md
diff --git a/README.md b/README.md
diff --git a/bin/nodemcu-tool.js b/bin/nodemcu-tool.js
diff --git a/docs/Examples.md b/docs/Examples.md
diff --git a/docs/ProgrammaticUsage.md b/docs/ProgrammaticUsage.md
diff --git a/docs/Reset_on_Connect.md b/docs/Reset_on_Connect.md
diff --git a/docs/nodemcu-reset-circuit.jpg b/docs/nodemcu-reset-circuit.jpg
diff --git a/examples/apache-ant-build.xml b/examples/apache-ant-build.xml
diff --git a/examples/parse-devicelist.py b/examples/parse-devicelist.py
diff --git a/examples/parse-filelist.php b/examples/parse-filelist.php
diff --git a/helloworld.lua b/helloworld.lua
diff --git a/lib/LuaCommandBuilder.js b/lib/LuaCommandBuilder.js
diff --git a/lib/LuaOptimizer.js b/lib/LuaOptimizer.js
diff --git a/lib/NodeMCU-Tool.js b/lib/NodeMCU-Tool.js
diff --git a/lib/NodeMcuConnector.js b/lib/NodeMcuConnector.js
diff --git a/lib/ScriptableSerialTerminal.js b/lib/ScriptableSerialTerminal.js
diff --git a/lib/SerialTerminal.js b/lib/SerialTerminal.js
@@ -50,7 +50,10 @@ SerialTerminal.prototype.passthrough = function(devicename, baudrate, cb){
         }else{
 
             // prepare
-            process.stdin.setRawMode(true);
+            if (process.stdin.isTTY){
+                process.stdin.setRawMode(true);
+            }
+
             process.stdin.setEncoding('utf8');
 
             // pass-through

diff --git a/nodemcu-tool b/nodemcu-tool
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nodemcu-tool",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "Command line tool to upload and manage files on your NodeMCU / ESP8266 Module.",
   "keywords": [
     "cli",

diff --git a/video.gif b/video.gif