Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Python application

on: [push]

permissions:
contents: read

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Set up Python 3.13
uses: actions/setup-python@v3
with:
python-version: "3.13"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install ruff
pip install pytest
- name: Lint with ruff
run: |
ruff check --output-format=github
- name: Test with pytest
run: |
pytest
8 changes: 8 additions & 0 deletions walker_scheme/test_walker.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from walker import Walker


def test():
test = Walker([("a", 0), ("b", 1)])
rand = test.get_random()
assert rand == 1

33 changes: 33 additions & 0 deletions walker_scheme/walker.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import random


class Walker:
def __init__(self, probabilities: list[tuple[str, float]]):
self.probabilities = sorted(probabilities, key=lambda x: x[1])
self.probabilities_walker = [[self.probabilities[i][0], 1 / len(self.probabilities)] for i in range(len(self.probabilities))]
summa = sum(probabilities[i][1] for i in range(len(probabilities)))
if summa != 1:
raise ValueError('Сумма вероятностей не равна единице')

def walker_scheme(self):
barrier = 0
for i in range(len(self.probabilities) - 1):
if self.probabilities[i][1] < self.probabilities_walker[i][1]:
self.probabilities_walker[i][1] = self.probabilities[i][1] + barrier
self.probabilities_walker[i + 1][1] += (self.probabilities_walker[i][1] - self.probabilities[i][1])
barrier = self.probabilities_walker[i][1]
elif self.probabilities[i][1] > self.probabilities_walker[i][1]:
self.probabilities_walker[i][1] = self.probabilities[i][1] + barrier
self.probabilities_walker[i + 1][1] -= (self.probabilities[i][1] - self.probabilities_walker[i][1])
barrier = self.probabilities_walker[i][1]
elif self.probabilities[i][1] == self.probabilities_walker[i][1]:
self.probabilities_walker[i][1] += barrier
barrier = self.probabilities_walker[i][1]
self.probabilities_walker[-1][1] += barrier
Comment on lines +12 to +26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот код почти невозможно читать. Вы тут используете очень много раз одно и то же, неужели вы не понимаете выгоды от того, чтобы обозначить это за новую переменную?? Это и эффективнее по времени, и лучше для понимания, и уменьшает шанс ошибки


def get_random(self):
probability = random.random()
self.walker_scheme()
for i in self.probabilities_walker:
if probability <= i[1]:
return i[0]
Comment on lines +31 to +33
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну и смысл тогда от схемы Уолкера, если тут по итогу всё равно цикл?

Loading