Skip to content

Comments

Rewrite control work c#11

Open
Andrew-Kochanov wants to merge 7 commits intomainfrom
rewriteControlWorkC
Open

Rewrite control work c#11
Andrew-Kochanov wants to merge 7 commits intomainfrom
rewriteControlWorkC

Conversation

@Andrew-Kochanov
Copy link
Owner

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Андрей! Вы читали, что я Вам про такую раскладку директорий писал????? Ну не работает оно так :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А флаги? (((

newNode->count = 1;
newNode->next = NULL;

newNode->next = list->head;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А зачем Вы стали делать циклический список?

ListNode* current = list->head;
while (current->next != NULL && current->next->value < value) {
current = current->next;
// printf("%d", current->next->value);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мертвый код

return;
} else if (current->value == value) {
current->count++;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Или здесь return не хватает, или просто нигде не нужен был

Comment on lines +7 to +11
List* newList();
void insert(List* list, int value);
bool deleteNode(List* list, int value);
void printList(List* list);
void deleteList(List* list); No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарии традиционно пишут в хедере

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну, память вроде не течёт. И идея здравая, странности есть, но это ведь контрольная :)

Comment on lines +145 to +150
if (list->head->value == 0) {
current = current->next;
miniNumber += current->value * pow(10, degree);
degree--;
degree = degree - tempDegree;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что происходит здесь я, честно говоря, так себе понимаю.

Comment on lines +151 to +157
while (current != NULL) {
for (int i = 0; i < current->count; i++) {
miniNumber += current->value * pow(10, degree);
degree--;
}
current = current->next;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Но вообще похоже на правду

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот были бы здесь тесты. А так я даже не понимаю, работает ли оно или нет :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants