Comprehensive safety, correctness, CI, and test improvements#3
Merged
AndrewAltimit merged 1 commit intomainfrom Feb 21, 2026
Merged
Comprehensive safety, correctness, CI, and test improvements#3AndrewAltimit merged 1 commit intomainfrom
AndrewAltimit merged 1 commit intomainfrom
Conversation
Phase 1 - Critical safety fixes: PTS overflow protection, frame size overflow checks, video dimension validation, seqlock multi-writer detection, PTS sentinel fix, GPU fence timeout bounds. Phase 2 - Robustness: DPI scale range validation, playback rate validation, clock jump detection, IPC race condition fix, swapchain handle lifecycle (OnceCell to Mutex), audio ring buffer wall-clock timeout, URL host-based validation. Phase 3 - CI/DX: Remove duplicate ci.yml, preserve Docker target cache, test parallelization, consolidate cleanup, fix silent cargo-deny install failure, local pre-commit hooks, exclude Cargo.lock from large file check. Phase 4 - Dependency hygiene: Centralize workspace deps (serde_json, clap, egui, wgpu, winit, once_cell), add openssl ban rule, remove stale bytes advisory. Phase 5 - Lint enforcement: Add undocumented_unsafe_blocks and missing_safety_doc clippy lints, add SAFETY comments to all unsafe blocks, add MessageType context to CRC errors, exponential backoff in shmem read_frame. Phase 6 - Test coverage: 33 new tests across itk-protocol (14), itk-shmem (7), and itk-sync (12) covering edge cases, boundary conditions, and error paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
25 files changed, 806 insertions, 205 deletions. Full CI passes (107 tests, clean clippy/fmt/cargo-deny).
Test plan
Generated with Claude Code