Open
Conversation
yurii-litvinov
suggested changes
Dec 31, 2024
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Да в целом всё хорошо, только чуть поправить error reporting
|
|
||
| Node* createOperationNode(char operation, Node* left, Node* right) { | ||
| Node* newNode = malloc(sizeof(Node)); | ||
| newNode->operation = operation; |
There was a problem hiding this comment.
Надо проверять результат malloc и сообщать вызывающему, если что-то пошло не так
hw8/parsingTree/parsingTree.c
Outdated
|
|
||
| skipSpace(file); | ||
| if (fgetc(file) != ')') { | ||
| exit(1); |
There was a problem hiding this comment.
Не используйте exit, используйте честный механизм обработки ошибок с кодами ошибок
hw8/parsingTree/parsingTree.c
Outdated
| return leftValue * rightValue; | ||
| case '/': | ||
| if (rightValue == 0) { | ||
| printf("Деление на ноль!\n"); |
There was a problem hiding this comment.
Не общайтесь с пользователем вне main-а
yurii-litvinov
approved these changes
Jan 12, 2025
| } | ||
| } | ||
|
|
||
| bool verify(int* errorCode) { |
There was a problem hiding this comment.
Можно было более подходящее название, например, printError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.