feat(i18n): Add language support for AI-generated content (v2.7.5) #1360
Conversation
Add complete Russian localization for the frontend UI including: - All 11 translation files (common, navigation, settings, tasks, welcome, onboarding, dialogs, gitlab, taskReview, terminal, errors) - Updated i18n constants to include Russian language option - Updated i18n index to import Russian translations This enables Russian-speaking users to use Auto-Claude in their native language. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: anatolijnesterov <acmasok@gmail.com>
- Pass language setting to ideation and roadmap generators - Add language instruction to AI prompts for non-English content - Support ru, fr, de, es, zh, ja, ko languages - Keep technical terms and code in English Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 Walkthrough🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @acmasok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive internationalization (i18n) support for AI-generated content within the Ideation and Roadmap features. It enables users to receive AI-generated text in their preferred language, enhancing accessibility and user experience for a global audience. The changes span both frontend and backend components, ensuring that language preferences are seamlessly propagated and applied during content generation, while maintaining English for technical elements. Additionally, a full Russian translation has been integrated into the frontend. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
В целом, этот pull request успешно добавляет поддержку русского языка для AI-генерируемого контента в разделах Ideation и Roadmap. Изменения в основном касаются добавления параметра языка в конфигурации бэкенда и фронтенда, а также обновления логики генерации подсказок для включения инструкций по языку. Также были добавлены файлы локализации для русского языка. Однако, обнаружена критическая проблема с файлом package-lock.json, где версия проекта откатывается с 2.7.5 на 2.7.4, что противоречит названию pull request и может привести к проблемам с зависимостями. Кроме того, есть возможность для улучшения поддерживаемости путем централизации списка названий языков в бэкенде.
package-lock.json
Outdated
| { | ||
| "name": "auto-claude", | ||
| "version": "2.7.5", | ||
| "version": "2.7.4", |
There was a problem hiding this comment.
Версия проекта в package-lock.json откатывается с 2.7.5 на 2.7.4. Это противоречит названию pull request, которое указывает на версию v2.7.5. Пожалуйста, убедитесь, что версия в package-lock.json соответствует ожидаемой версии 2.7.5, чтобы избежать проблем с зависимостями и развертыванием.
| "version": "2.7.4", | |
| "version": "2.7.5", |
package-lock.json
Outdated
| "": { | ||
| "name": "auto-claude", | ||
| "version": "2.7.5", | ||
| "version": "2.7.4", |
There was a problem hiding this comment.
Версия проекта в package-lock.json откатывается с 2.7.5 на 2.7.4. Это противоречит названию pull request, которое указывает на версию v2.7.5. Пожалуйста, убедитесь, что версия в package-lock.json соответствует ожидаемой версии 2.7.5, чтобы избежать проблем с зависимостями и развертыванием.
| "version": "2.7.4", | |
| "version": "2.7.5", |
package-lock.json
Outdated
| "apps/frontend": { | ||
| "name": "auto-claude-ui", | ||
| "version": "2.7.5", | ||
| "version": "2.7.4", |
There was a problem hiding this comment.
Версия проекта в package-lock.json откатывается с 2.7.5 на 2.7.4. Это противоречит названию pull request, которое указывает на версию v2.7.5. Пожалуйста, убедитесь, что версия в package-lock.json соответствует ожидаемой версии 2.7.5, чтобы избежать проблем с зависимостями и развертыванием.
| "version": "2.7.4", | |
| "version": "2.7.5", |
| language_names = { | ||
| "ru": "Russian", | ||
| "fr": "French", | ||
| "de": "German", | ||
| "es": "Spanish", | ||
| "zh": "Chinese", | ||
| "ja": "Japanese", | ||
| "ko": "Korean", |
There was a problem hiding this comment.
Словарь language_names жестко закодирован здесь. Если потребуется добавить больше языков, этот словарь придется обновлять в нескольких местах (например, в roadmap/executor.py). Рассмотрите возможность централизации этого списка языков в одном файле конфигурации или базе данных, чтобы улучшить поддерживаемость.
| language_names = { | ||
| "ru": "Russian", | ||
| "fr": "French", | ||
| "de": "German", | ||
| "es": "Spanish", | ||
| "zh": "Chinese", | ||
| "ja": "Japanese", | ||
| "ko": "Korean", |
There was a problem hiding this comment.
Как и в ideation/generator.py, словарь language_names жестко закодирован здесь. Для лучшей поддерживаемости и масштабируемости рассмотрите возможность централизации этого списка языков в одном файле конфигурации или базе данных, чтобы избежать дублирования и упростить добавление новых языков в будущем.
There was a problem hiding this comment.
Pull request overview
This PR adds language support for AI-generated content in the Ideation and Roadmap sections. The language setting from the app preferences is now passed through to the AI content generators, enabling multilingual content generation while keeping technical terms, file paths, and code in English.
Changes:
- Added language parameter support throughout the frontend and backend pipeline
- Implemented Russian (ru) UI translations with comprehensive localization files
- Added language instruction injection into AI prompts for supported languages (Russian, French, German, Spanish, Chinese, Japanese, Korean)
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Version downgrade from 2.7.5 to 2.7.4 (critical issue) |
| apps/frontend/src/shared/types/insights.ts | Added language property to IdeationConfig type |
| apps/frontend/src/shared/constants/i18n.ts | Added Russian to supported languages |
| apps/frontend/src/shared/i18n/index.ts | Imported and registered Russian translation resources |
| apps/frontend/src/shared/i18n/locales/ru/*.json | Complete Russian UI translations (11 files) |
| apps/frontend/src/main/ipc-handlers/generation-handlers.ts | Read language from settings and pass to ideation config |
| apps/frontend/src/main/ipc-handlers/roadmap-handlers.ts | Read language from settings and pass to roadmap config |
| apps/frontend/src/main/agent/types.ts | Added language property to RoadmapConfig interface |
| apps/frontend/src/main/agent/agent-queue.ts | Pass --language argument to backend processes |
| apps/backend/runners/ideation_runner.py | Accept --language CLI argument |
| apps/backend/runners/roadmap_runner.py | Accept --language CLI argument |
| apps/backend/ideation/generator.py | Add language instruction to AI prompts |
| apps/backend/runners/roadmap/executor.py | Add language instruction to AI prompts |
| apps/backend/ideation/types.py | Added language property to IdeationConfig dataclass |
| apps/backend/runners/roadmap/models.py | Added language property to RoadmapConfig dataclass |
| apps/backend/ideation/config.py | Pass language through configuration chain |
| apps/backend/ideation/runner.py | Accept and pass language parameter |
| apps/backend/runners/roadmap/orchestrator.py | Accept and pass language parameter |
| CHANGELOG.md | Documented new features for v2.7.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
apps/backend/runners/roadmap/executor.py (1)
69-83: Normalize/validatelanguagebefore prompt injection.
Casing or unexpected values (e.g.,EN,en-US, or arbitrary strings) will be injected into the prompt and can produce inconsistent output. Normalize the code and only apply the instruction for supported languages.🛠️ Proposed fix
- self.language = language + self.language = (language or "en").lower() @@ - if self.language and self.language != "en": + if self.language != "en": language_names = { "ru": "Russian", "fr": "French", "de": "German", "es": "Spanish", "zh": "Chinese", "ja": "Japanese", "ko": "Korean", } - lang_name = language_names.get(self.language, self.language) - prompt += f"\n**IMPORTANT - Output Language**: Generate ALL text content (vision, descriptions, feature names, rationale, explanations) in {lang_name}. Keep only technical terms, file paths, and code in English.\n" + lang_name = language_names.get(self.language) + if lang_name: + prompt += ( + f"\n**IMPORTANT - Output Language**: Generate ALL text content " + f"(vision, descriptions, feature names, rationale, explanations) " + f"in {lang_name}. Keep only technical terms, file paths, and code in English.\n" + )Also applies to: 116-128
apps/frontend/src/main/ipc-handlers/ideation/generation-handlers.ts (1)
71-84: Consider addinglanguageto debug logging for consistency.The
configWithSettingsobject includeslanguage, but the debug log on lines 78-84 omits it. For consistency with roadmap handlers (which log the full config), consider addinglanguageto the logged properties.♻️ Add language to debug logging
debugLog("[Ideation Handler] Start generation request:", { projectId, enabledTypes: configWithSettings.enabledTypes, maxIdeasPerType: configWithSettings.maxIdeasPerType, model: configWithSettings.model, thinkingLevel: configWithSettings.thinkingLevel, + language: configWithSettings.language, });apps/backend/runners/roadmap_runner.py (1)
103-136: Consider addinglanguageto the debug log for observability.The debug statement on lines 103-110 logs several CLI arguments but omits
language. For debugging and troubleshooting language-related issues, consider including it.♻️ Add language to debug logging
debug( "roadmap_runner", "CLI invoked", project=str(args.project), output=str(args.output) if args.output else None, model=args.model, refresh=args.refresh, + language=args.language, )apps/backend/ideation/config.py (1)
20-71: Validate/normalizelanguagebefore it reaches prompt construction.
Iflanguageis user-configurable, passing it through unchecked can allow unsupported values or prompt-injection-like strings. Add a small allowlist/normalization here (or a shared validator) and default to"en"on invalid input.🔧 Proposed guardrail
+ALLOWED_LANGUAGES = {"en", "ru", "fr", "de", "es", "zh", "ja", "ko"} + class IdeationConfigManager: @@ - self.language = language + normalized_language = language.strip().lower() + self.language = ( + normalized_language if normalized_language in ALLOWED_LANGUAGES else "en" + )apps/backend/runners/roadmap/orchestrator.py (1)
26-66: Add language validation to prevent prompt injection in both roadmap and ideation paths.The
languageparameter lacks validation at both the CLI and orchestrator levels. Users can pass arbitrary strings that get interpolated directly into LLM prompts via the.get()fallback at lines 127 (roadmap/executor.py) and 103 (ideation/generator.py). For example,--language "en\n\nIGNORE_INSTRUCTIONS"would inject unescaped content into the system prompt.Unlike
thinking_level(which useschoices=["none", "low", "medium", "high", "ultrathink"]), the--languageargument has nochoicesconstraint, allowing any string through. The executor's fallbacklanguage_names.get(self.language, self.language)returns the raw unsanitized value when not found in the mapping, then embeds it directly into the prompt string without escaping.Add a shared validation constant and normalize the language in both
RoadmapOrchestrator.__init__(line 44) and the equivalent ideation runner initialization:🔧 Suggested fix
+# At module level (shared across both orchestrator and ideation) +SUPPORTED_LANGUAGES = {"en", "ru", "fr", "de", "es", "zh", "ja", "ko"} + def __init__( self, project_dir: Path, @@ -44,7 +47,10 @@ class RoadmapOrchestrator: self.enable_competitor_analysis = enable_competitor_analysis self.refresh_competitor_analysis = refresh_competitor_analysis - self.language = language + normalized_language = language.strip().lower() + self.language = ( + normalized_language if normalized_language in SUPPORTED_LANGUAGES else "en" + )
🤖 Fix all issues with AI agents
In `@apps/backend/ideation/generator.py`:
- Around line 92-104: The inline language_names dict inside the method using
self.language should be extracted to a shared module-level constant (e.g.,
LANGUAGE_NAMES) so it isn't recreated on every call and can be reused across
files; create the constant at top of apps/backend/ideation/generator.py (or a
shared util module if used by other modules like roadmap/executor.py), replace
the inline language_names reference in the method with
LANGUAGE_NAMES.get(self.language, self.language), and update imports/usages
accordingly to use the shared constant.
In `@apps/backend/runners/ideation_runner.py`:
- Around line 125-130: The --language parser.add_argument currently accepts any
string; add validation similar to the existing --types handling by restricting
accepted values (either via argparse's choices or by checking against a
SUPPORTED_LANGUAGES list) and surface a clear error for invalid codes; update
the --language add_argument call (the parser.add_argument for "--language") to
use choices=<SUPPORTED_LANGUAGES> or validate the parsed args.language against
SUPPORTED_LANGUAGES (create that constant if needed) and raise/argparse.error
with a helpful message on invalid input.
In `@apps/frontend/src/shared/types/insights.ts`:
- Line 31: Replace the loose string type on the language property with the
specific SupportedLanguage type: import SupportedLanguage from
apps/frontend/src/shared/constants/i18n.ts and change the declaration language?:
string to language?: SupportedLanguage in the insights type (referencing the
existing language property in apps/frontend/src/shared/types/insights.ts); also
update the trailing comment to remove "etc." and note only 'en' | 'fr' | 'ru'
are supported so the comment matches the constrained type.
| # Add language instruction if not English | ||
| if self.language and self.language != "en": | ||
| language_names = { | ||
| "ru": "Russian", | ||
| "fr": "French", | ||
| "de": "German", | ||
| "es": "Spanish", | ||
| "zh": "Chinese", | ||
| "ja": "Japanese", | ||
| "ko": "Korean", | ||
| } | ||
| lang_name = language_names.get(self.language, self.language) | ||
| prompt += f"\n**IMPORTANT - Output Language**: Generate ALL text content (titles, descriptions, rationale, implementation approaches) in {lang_name}. Keep only technical terms, file paths, and code in English.\n" |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider extracting the language names mapping as a module-level constant.
The implementation correctly injects language instructions only for non-English languages. However, the language_names dictionary is defined inline within the method, which means it gets recreated on every call. Additionally, this same mapping likely exists (or will exist) in other files like roadmap/executor.py.
♻️ Suggested refactor to extract constant
+# Language code to full name mapping for AI prompts
+LANGUAGE_NAMES = {
+ "ru": "Russian",
+ "fr": "French",
+ "de": "German",
+ "es": "Spanish",
+ "zh": "Chinese",
+ "ja": "Japanese",
+ "ko": "Korean",
+}
+
+
class IdeationGenerator:Then in the method:
# Add language instruction if not English
if self.language and self.language != "en":
- language_names = {
- "ru": "Russian",
- "fr": "French",
- "de": "German",
- "es": "Spanish",
- "zh": "Chinese",
- "ja": "Japanese",
- "ko": "Korean",
- }
- lang_name = language_names.get(self.language, self.language)
+ lang_name = LANGUAGE_NAMES.get(self.language, self.language)
prompt += f"\n**IMPORTANT - Output Language**: Generate ALL text content (titles, descriptions, rationale, implementation approaches) in {lang_name}. Keep only technical terms, file paths, and code in English.\n"🤖 Prompt for AI Agents
In `@apps/backend/ideation/generator.py` around lines 92 - 104, The inline
language_names dict inside the method using self.language should be extracted to
a shared module-level constant (e.g., LANGUAGE_NAMES) so it isn't recreated on
every call and can be reused across files; create the constant at top of
apps/backend/ideation/generator.py (or a shared util module if used by other
modules like roadmap/executor.py), replace the inline language_names reference
in the method with LANGUAGE_NAMES.get(self.language, self.language), and update
imports/usages accordingly to use the shared constant.
| parser.add_argument( | ||
| "--language", | ||
| type=str, | ||
| default="en", | ||
| help="Language for generated content (en, ru, fr, etc.)", | ||
| ) |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider validating the --language argument.
The CLI argument is correctly added with appropriate help text. However, unlike --types (which validates against IDEATION_TYPES at lines 144-148), invalid language codes will pass through without early feedback.
♻️ Optional: Add language validation
+SUPPORTED_LANGUAGES = ["en", "ru", "fr", "de", "es", "zh", "ja", "ko"]
+
# ...
parser.add_argument(
"--language",
type=str,
default="en",
- help="Language for generated content (en, ru, fr, etc.)",
+ choices=SUPPORTED_LANGUAGES,
+ help=f"Language for generated content (options: {', '.join(SUPPORTED_LANGUAGES)})",
)Using choices provides argparse-level validation with automatic error messages.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| parser.add_argument( | |
| "--language", | |
| type=str, | |
| default="en", | |
| help="Language for generated content (en, ru, fr, etc.)", | |
| ) | |
| SUPPORTED_LANGUAGES = ["en", "ru", "fr", "de", "es", "zh", "ja", "ko"] | |
| # ... [existing code] | |
| parser.add_argument( | |
| "--language", | |
| type=str, | |
| default="en", | |
| choices=SUPPORTED_LANGUAGES, | |
| help=f"Language for generated content (options: {', '.join(SUPPORTED_LANGUAGES)})", | |
| ) |
🤖 Prompt for AI Agents
In `@apps/backend/runners/ideation_runner.py` around lines 125 - 130, The
--language parser.add_argument currently accepts any string; add validation
similar to the existing --types handling by restricting accepted values (either
via argparse's choices or by checking against a SUPPORTED_LANGUAGES list) and
surface a clear error for invalid codes; update the --language add_argument call
(the parser.add_argument for "--language") to use choices=<SUPPORTED_LANGUAGES>
or validate the parsed args.language against SUPPORTED_LANGUAGES (create that
constant if needed) and raise/argparse.error with a helpful message on invalid
input.
| append?: boolean; // If true, append to existing ideas instead of replacing | ||
| model?: string; // Model shorthand (opus, sonnet, haiku) | ||
| thinkingLevel?: string; // Thinking level (none, low, medium, high, ultrathink) | ||
| language?: string; // Language for generated content (en, ru, fr, etc.) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for SupportedLanguage type and AVAILABLE_LANGUAGES constant
rg -n "SupportedLanguage|AVAILABLE_LANGUAGES" --type=ts --type=tsx apps/frontend/src/shared/
# Also check the i18n.ts constants file directly
echo "=== Checking i18n.ts file ==="
find apps/frontend/src/shared/constants -name "*i18n*" -type fRepository: AndyMik90/Auto-Claude
Length of output: 182
🏁 Script executed:
#!/bin/bash
# Check the insights.ts file to see the full context of the IdeationConfig type
head -50 apps/frontend/src/shared/types/insights.tsRepository: AndyMik90/Auto-Claude
Length of output: 1922
🏁 Script executed:
#!/bin/bash
# Search for usage of IdeationConfig and language property
rg -n "IdeationConfig|language:" --type=ts --type=tsx apps/frontend/src/ -A 2 -B 2 | head -100Repository: AndyMik90/Auto-Claude
Length of output: 92
🏁 Script executed:
#!/bin/bash
# Read the i18n.ts constants file
cat apps/frontend/src/shared/constants/i18n.tsRepository: AndyMik90/Auto-Claude
Length of output: 518
🏁 Script executed:
#!/bin/bash
# Search for AVAILABLE_LANGUAGES with rg (simpler search)
rg "AVAILABLE_LANGUAGES" apps/frontend/src/shared/Repository: AndyMik90/Auto-Claude
Length of output: 144
🏁 Script executed:
#!/bin/bash
# Search for where language property is used
rg "language" apps/frontend/src/ -B 2 -A 2 | head -80Repository: AndyMik90/Auto-Claude
Length of output: 6077
🏁 Script executed:
#!/bin/bash
# Check how IdeationConfig is actually used to see if changing the type would break anything
rg "IdeationConfig" apps/frontend/src/ -B 2 -A 5Repository: AndyMik90/Auto-Claude
Length of output: 23388
🏁 Script executed:
#!/bin/bash
# Check RoadmapConfig to see if it has the same issue
rg "RoadmapConfig" apps/frontend/src/ -B 2 -A 8 | grep -A 8 "interface RoadmapConfig"Repository: AndyMik90/Auto-Claude
Length of output: 755
Use SupportedLanguage type instead of generic string for better type safety and consistency.
Import SupportedLanguage from apps/frontend/src/shared/constants/i18n.ts and change the type from language?: string to language?: SupportedLanguage. This ensures the language property is restricted to the three supported languages ('en' | 'fr' | 'ru') and maintains consistency with how settings.ts types the UI language preference. Also update the comment to remove the misleading "etc." since only these three languages are currently supported.
🤖 Prompt for AI Agents
In `@apps/frontend/src/shared/types/insights.ts` at line 31, Replace the loose
string type on the language property with the specific SupportedLanguage type:
import SupportedLanguage from apps/frontend/src/shared/constants/i18n.ts and
change the declaration language?: string to language?: SupportedLanguage in the
insights type (referencing the existing language property in
apps/frontend/src/shared/types/insights.ts); also update the trailing comment to
remove "etc." and note only 'en' | 'fr' | 'ru' are supported so the comment
matches the constrained type.
The recovery agent was generating content in English even when language was set to Russian because it didn't include the language instruction in its prompt. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
AndyMik90
force-pushed
the
develop
branch
2 times, most recently
from
67a743f to
e83e445
Compare
|
Dear @AndyMik90 , chance to get this reviewed/merged soon? |
3 participants
Summary
Adds language support for AI-generated content in Ideation and Roadmap sections. Closes #1359.
Changes
Frontend
generation-handlers.ts- readssettings.languageand passes to configroadmap-handlers.ts- readssettings.languageand passes to configagent-queue.ts- passes--languageargument to backend processestypes.ts,insights.ts- addedlanguageproperty to typesBackend
ideation_runner.py- accepts--languageCLI argumentroadmap_runner.py- accepts--languageCLI argumentideation/generator.py- adds language instruction to AI promptsroadmap/executor.py- adds language instruction to AI promptsroadmap/orchestrator.py,models.py- passes language through the chainSupported Languages
Behavior
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.