Fix old proxyAdmin checking logic

AngelProtocolFinance · Sep 13, 2023 · 2a4cecc · 2a4cecc
1 parent 066c59e
commit 2a4cecc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/contract-address.json b/contract-address.json
@@ -374,7 +374,7 @@
         "factory": "0x790094B9fdC8C8a83507f7Eb275DEe903Ffd71eD",
         "implementation": "0x562EcE7daE572a5352D50562C472CBd41402F310"
       },
-      "proxyAdmin": "0x0d60924d99B5C75Ce8A6698b44Fa864fdC84A2C9"
+      "proxyAdmin": "0x79AF01164e25B9c6Ff828A5f795CFA62A635CFC3"
     },
     "registrar": {
       "implementation": "0xfC8caFA21dc76a1065494E213dE9F94E788DaAC9",

diff --git a/tasks/manage/changeProxyAdmin.ts b/tasks/manage/changeProxyAdmin.ts
@@ -37,12 +37,13 @@ task("manage:changeProxyAdmin", "Will update the proxy admin the target proxy co
 
       const proxyAdminOwner = await getProxyAdminOwner(hre, taskArgs.proxyAdminPkey);
 
-      if (addresses.multiSig.proxyAdmin === targetAddress) {
+      const proxyContract = ProxyContract__factory.connect(taskArgs.proxy, hre.ethers.provider);
+      const curAdmin = await proxyContract.getAdmin();
+
+      if (curAdmin === targetAddress) {
         return logger.out(`"${targetAddress}" is already the proxy admin.`);
       }
 
-      const proxyContract = ProxyContract__factory.connect(taskArgs.proxy, hre.ethers.provider);
-      const curAdmin = await proxyContract.getAdmin();
       logger.out(`Current Admin: ${curAdmin}`);
 
       // submitting the Tx