EndowmentCreated event: add name (string) (#379)

* EndowmentCreated event: add name (string) * Update contracts/core/accounts/interfaces/IAccountsEvents.sol Co-authored-by: Nenad Misic <nenad@angelprotocol.io> * fix tests --------- Co-authored-by: Andrey <SovereignAndrey> Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
AngelProtocolFinance · Sep 14, 2023 · af39b10 · af39b10
1 parent d6bd545
commit af39b10
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/contracts/core/accounts/facets/AccountsCreateEndowment.sol b/contracts/core/accounts/facets/AccountsCreateEndowment.sol
@@ -129,6 +129,6 @@ contract AccountsCreateEndowment is
       );
     }
 
-    emit EndowmentCreated(newEndowId, details.endowType);
+    emit EndowmentCreated(newEndowId, details.endowType, details.name);
   }
 }
diff --git a/contracts/core/accounts/interfaces/IAccountsEvents.sol b/contracts/core/accounts/interfaces/IAccountsEvents.sol
@@ -14,7 +14,7 @@ interface IAccountsEvents {
     uint256 added,
     uint256 deducted
   );
-  event EndowmentCreated(uint256 endowId, LibAccounts.EndowmentType endowType);
+  event EndowmentCreated(uint256 endowId, LibAccounts.EndowmentType endowType, string name);
   event EndowmentUpdated(uint256 endowId);
   event EndowmentClosed(uint256 endowId, LibAccounts.Beneficiary beneficiary, uint32[] relinked);
   event EndowmentDeposit(

diff --git a/test/core/accounts/AccountsCreateEndowment.ts b/test/core/accounts/AccountsCreateEndowment.ts
@@ -307,7 +307,7 @@ describe("AccountsCreateEndowment", function () {
 
     await expect(facet.connect(charityApplications).createEndowment(request))
       .to.emit(facet, "EndowmentCreated")
-      .withArgs(expectedNextAccountId, request.endowType);
+      .withArgs(expectedNextAccountId, request.endowType, request.name);
 
     const result = await state.getEndowmentDetails(expectedNextAccountId);
 
@@ -400,7 +400,7 @@ describe("AccountsCreateEndowment", function () {
 
     await expect(facet.connect(charityApplications).createEndowment(request))
       .to.emit(facet, "EndowmentCreated")
-      .withArgs(expectedNextAccountId, 0);
+      .withArgs(expectedNextAccountId, 0, request.name);
 
     const result = await state.getEndowmentDetails(expectedNextAccountId);