This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Missing validation in MultiSigs ( + enable "clean compile" in bash script) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
commented
Aug 1, 2023
| @@ -4,7 +4,11 @@ | |||
| set -x; | |||
| # Shuttle `tasks/index.ts` file to temp file before cleaning/compiling starts | |||
| mv -n ./tasks/index.ts ./tasks/temp_index.ts && touch ./tasks/index.ts; | |||
| # Clean and compile all contracts. | |||
| # Clean if necessary | |||
There was a problem hiding this comment.
To run "clean compile" simply type the command with the argument clean, like:
yarn compile cleanIf for whatever reason you had a corrupt /typechain-types folder, causing missing types in tasks and you tried to performing npx hardhat clean to recompile everything from scratch, the command would fail because it would first be necessary to perform "Shuttle tasks/index.ts file to temp file before cleaning/compiling starts" from above (otherwise you'd be stuck).
By letting us pass an argument "clean" to this bash script, we enable ourselves to be "unstuck" without having to first do any other setup to ignore the compilation errors.
0xNeshi
changed the title
SovereignAndrey
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the solution
See commits.
Instructions on making this work
yarnoryarn installto install npm dependencies