Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Fixed regression in Router test #291

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fixed regression in Router test #291

merged 1 commit into from
Aug 9, 2023

Conversation

stevieraykatz
Copy link
Contributor

Closes all failing CI issues with:

/usr/local/bin/yarn tsc
Error: test/core/router/Router.ts(458,13): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'string'.
Error: test/core/router/Router.ts(478,13): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'string'.
Error: test/core/router/Router.ts(498,13): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'string'.
Error: test/core/router/Router.ts(540,13): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'string'.
Error: test/core/router/Router.ts(560,13): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'string'.
Error: test/core/router/Router.ts(820,9): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'string'.
Error: The process '/usr/local/bin/yarn' failed with exit code 2

Explanation of the solution

looks like some old lines of the Router test snuck in upon merge? either way, no need to query a mock contract for symbol. can specify directly to save runtime.

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@SovereignAndrey SovereignAndrey merged commit cf21ed0 into master Aug 9, 2023
1 check failed
@SovereignAndrey SovereignAndrey deleted the fix-failing-CI branch August 9, 2023 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants