Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Closes AP-727, AP-791: EndowmentMultiSig proxy admin update & update EndowmentMultiSigFactory's registrar on new Registrar deployment #377

Merged
merged 56 commits into from
Sep 20, 2023
Merged

Closes AP-727, AP-791: EndowmentMultiSig proxy admin update & update EndowmentMultiSigFactory's registrar on new Registrar deployment #377

merged 56 commits into from
Sep 20, 2023
+569 −170

Commits on Sep 19, 2023

  1. Validate addresses using Validator

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f89f68b View commit details
    Browse the repository at this point in the history

  2. Move events to IEndowmentMultiSigFactory

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2a03bc4 View commit details
    Browse the repository at this point in the history

  3. Use InvalidAddress error instead of requires

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    93e1ecc View commit details
    Browse the repository at this point in the history

  4. Use OnlyAccountsContract error in onlyAccountsContract

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c853729 View commit details
    Browse the repository at this point in the history

  5. Add updateRegistrar function

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2631087 View commit details
    Browse the repository at this point in the history

  6. Add Initialized event

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    39a5e22 View commit details
    Browse the repository at this point in the history

  7. Add missing getInstantiationCount function to interface

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9e05fae View commit details
    Browse the repository at this point in the history

  8. Remove unused factory param in upgrade:endowmentMultiSig:emitter

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    056010e View commit details
    Browse the repository at this point in the history

  9. Add getRegistrarAddress function

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b51a8f2 View commit details
    Browse the repository at this point in the history

  10. Add manage:endowmentMultiSigFactory:updateRegistrar task

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    add7d70 View commit details
    Browse the repository at this point in the history

  11. Add call to manage:endowmentMultiSigFactory:updateRegistrar to deploy… 

    …:Registrar task
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    138ccea View commit details
    Browse the repository at this point in the history

  12. Remove unused errors from IterableMappingAddr

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    dd8ac93 View commit details
    Browse the repository at this point in the history

  13. Remove unused IterableMappingAddr import from LibAccounts

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1bde47b View commit details
    Browse the repository at this point in the history

  14. Remove endowmentIdToMultisig mapping

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    de3b317 View commit details
    Browse the repository at this point in the history

  15. Remove getInstantiationCount

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b30f992 View commit details
    Browse the repository at this point in the history

  16. Add endowmentMultiSigs IterableMappingAddr.Map

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e8844e6 View commit details
    Browse the repository at this point in the history

  17. Add back isInstantiation function

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a2ad3cb View commit details
    Browse the repository at this point in the history

  18. Refactor constructor + remove Initialized event

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bc8853b View commit details
    Browse the repository at this point in the history

  19. Rename register > endowmentMultiSigProxy to instantiation

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    66217ef View commit details
    Browse the repository at this point in the history

  20. Update comments

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a6432d4 View commit details
    Browse the repository at this point in the history

  21. Implement getInstantiations function

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d246012 View commit details
    Browse the repository at this point in the history

  22. Rename getRegistrarAddress -> getRegistrar (+ add comment)

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    cb5ff18 View commit details
    Browse the repository at this point in the history

  23. Update EndowmentMultiSig Proxies' addresses in manage:changeProxyAdmi… 

    …n task
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ae6a0c8 View commit details
    Browse the repository at this point in the history

  24. Update comment for newProxyAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    870d164 View commit details
    Browse the repository at this point in the history

  25. Make proxyAdmin field internal and access through getProxyAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9163786 View commit details
    Browse the repository at this point in the history

  26. Rename changeProxyAdmin->changeProxyAdminForAll and fix logic

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e897e52 View commit details
    Browse the repository at this point in the history

  27. Create manage:changeProxyAdmin task

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d35ed0c View commit details
    Browse the repository at this point in the history

  28. Update comment in updateRegistrar

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    285a01a View commit details
    Browse the repository at this point in the history

  29. Update logging logic

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9e3cb76 View commit details
    Browse the repository at this point in the history

  30. Refactor tasks/manage/changeProxyAdmin.ts

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b67a2d7 View commit details
    Browse the repository at this point in the history

  31. Update manage:changeProxyAdminForAll to use changeProxyAdmin task

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d0939bd View commit details
    Browse the repository at this point in the history

  32. Add manage:endowmentMultiSigFactory:updateProxyAdmin task

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bb537d1 View commit details
    Browse the repository at this point in the history

  33. Call manage:endowmentMultiSigFactory:updateProxyAdmin in changeProxyA… 

    …dminForAll
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    33f865a View commit details
    Browse the repository at this point in the history

  34. Update log 'Submitting Tx...' to comment

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    43a8231 View commit details
    Browse the repository at this point in the history

  35. Make 'to' optional, read from contract-address.json if null

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3f8b77f View commit details
    Browse the repository at this point in the history

  36. Fix old proxyAdmin checking logic

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1921ac9 View commit details
    Browse the repository at this point in the history

  37. Target curAdmin when submitting Tx to changeProxyAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4568c56 View commit details
    Browse the repository at this point in the history

  38. submitMultiSigTx > owner -> msOwner

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    cc670ee View commit details
    Browse the repository at this point in the history

  39. Remove redundant log in update reg. config

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c9459a3 View commit details
    Browse the repository at this point in the history

  40. Fix tasks/manage/changeProxyAdmin.ts

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    73490ce View commit details
    Browse the repository at this point in the history

  41. Fix tasks/manage/changeProxyAdminForAll.ts

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4e0f4c5 View commit details
    Browse the repository at this point in the history

  42. Add divider to changeProxyAdminForAll > changeProxiesAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    37e8441 View commit details
    Browse the repository at this point in the history

  43. Remove temp_task import

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2da8830 View commit details
    Browse the repository at this point in the history

  44. Revert contract-address.json

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    92c0cc8 View commit details
    Browse the repository at this point in the history

  45. Remove isInstantiation

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2708898 View commit details
    Browse the repository at this point in the history

  46. Refactor manage:endowmentMultiSigFactory:updateProxyAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    73aaa90 View commit details
    Browse the repository at this point in the history

  47. Minor refactor manage:registrar:updateConfig

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f16dc42 View commit details
    Browse the repository at this point in the history

  48. Add comment to updateEndowmentMultiSigFactory

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    db70fba View commit details
    Browse the repository at this point in the history

  49. Remove mention in EndowmentMultiSigFactory

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3853daa View commit details
    Browse the repository at this point in the history

  50. Revert "Remove unused errors from IterableMappingAddr" 

    This reverts commit 81e414d.
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ac6a68a View commit details
    Browse the repository at this point in the history

  51. Revert "Remove unused IterableMappingAddr import from LibAccounts" 

    This reverts commit 4b7c78f.
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    cd97aba View commit details
    Browse the repository at this point in the history

  52. Revert "Revert "Remove unused IterableMappingAddr import from LibAcco… 

    …unts""

This reverts commit 9c6a062.
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ca09a49 View commit details
    Browse the repository at this point in the history

  53. Revert "Revert "Remove unused errors from IterableMappingAddr"" 

    This reverts commit 98756ce.
    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7174fd7 View commit details
    Browse the repository at this point in the history

  54. Add basic checkIfProxyAdmin to changeProxyAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    113a36c View commit details
    Browse the repository at this point in the history

  55. Move checkIfProxyAdmin to checkIfManagedByProxyAdmin

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4bd7310 View commit details
    Browse the repository at this point in the history

  56. Fix issues after rebase

    @0xNeshi
    0xNeshi committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8fe4f63 View commit details
    Browse the repository at this point in the history