Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

AP-792: Add missing endowment contracts-related and VaultEmitter-related tasks #380

Merged
merged 12 commits into from
Sep 15, 2023

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Sep 14, 2023

Explanation of the solution

  • split deployEndowmentMultiSig -> from deploying all endowment-related contracts, split it into 3 separate functions deploying each individual contract separately
  • related to former -> create separate deployEndowmentMultiSig(/Emitter/Factory) tasks
  • add missing upgrade:VaultEmitter task
  • create helper upgradeProxy function (upgrades proxy implementation for the given contract)
  • update isProdNetwork to accept hreOrChainId: HardhatRuntimeEnvironment | number param -> makes it possible to check whether a given chain ID is of a prod network (no need to pass hre around)
  • apply deploy delay only on prod. networks + use wait(num_of_blocks) instead of delay(secs)
  • minor logging fixes

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@0xNeshi 0xNeshi added the enhancement New feature or request label Sep 14, 2023
@0xNeshi 0xNeshi self-assigned this Sep 14, 2023
@0xNeshi 0xNeshi changed the title Missing tasks AP-792: Add missing endowment contracts-related and VaultEmitter-related tasks Sep 14, 2023
@linear
Copy link

linear bot commented Sep 14, 2023

AP-792 Add missing endowment contracts-related and VaultEmitter-related tasks

Needed to upgrade relevant contracts' proxies on testnet and mainnet

@0xNeshi 0xNeshi merged commit ca0d287 into master Sep 15, 2023
1 check passed
@0xNeshi 0xNeshi deleted the missing-tasks branch September 15, 2023 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants