Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Testnet dummy strategy Deployment and associated fixes #381

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

stevieraykatz
Copy link
Contributor

Explanation of the solution

  • Deployed new side-chain contracts
  • Upgraded the AccountsStrategy facet to include most recent changes
  • Made necessary param updates to registrars on both chains
  • Fixed some tasks

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

Comment on lines +31 to +50
if(await isProdNetwork(hre)) {
await hre.run("manage:registrar:setStratParams:on-network", {
...taskArguments,
chainId: ChainID.polygon,
});
await hre.run("manage:registrar:setStratParams:on-network", {
...taskArguments,
chainId: config.chainId,
});
}
else {
await hre.run("manage:registrar:setStratParams:on-network", {
...taskArguments,
chainId: ChainID.mumbai,
});
await hre.run("manage:registrar:setStratParams:on-network", {
...taskArguments,
chainId: config.chainId,
});
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misicnenad do you prefer this ternary implementation? I couldn't decide whether it was cleaner or not:

      await hre.run("manage:registrar:setStratParams:on-network", {
        ...taskArguments,
        chainId: (await isProdNetwork(hre) ? ChainID.polygon : ChainID.mumbai),
      });
      await hre.run("manage:registrar:setStratParams:on-network", {
        ...taskArguments,
        chainId: config.chainId,
      });

@SovereignAndrey SovereignAndrey merged commit 0c6ccb5 into master Sep 15, 2023
1 check passed
@SovereignAndrey SovereignAndrey deleted the testnet-strategy branch September 15, 2023 12:11
@stevieraykatz stevieraykatz self-assigned this Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants