update AngleSharp and AngleSharp.Css #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Yeah I've been waiting for the css package to move to V1. Looks like we're close. |
egil
requested changes
Jun 28, 2023
Co-authored-by: Egil Hansen <egil@assimilated.dk>
|
Hmm now that I think about it, I do not think we can push a none-preview version out which depends on preview packages? so perhaps lets version it as 1.0.0-preview until CSS package is v1. @FlorianRappl what do you think? |
|
Well we could do it (publish something that is based on a preview) but I fully agree that waiting for AngleSharp.Css 1.0.0 is the right move! |
|
I keep running into issues with wanting to use AngleSharp v1 and not being able to, so pushed an updated that ignores the preview release of css. Diffing doesn't need all css features, in realilty just the parsing of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so the nugets r all in sync