Fix issue 1075 where triangulation fails on a simple polygon#1077
Open
baobaotuo wants to merge 1 commit intoAngusJohnson:mainfrom
Open
Fix issue 1075 where triangulation fails on a simple polygon#1077baobaotuo wants to merge 1 commit intoAngusJohnson:mainfrom
baobaotuo wants to merge 1 commit intoAngusJohnson:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the help from Claude, this pull request fixes a bug in triangulation reported in 1075.
The issue is that the same vPrev can be pushed more than once in
locMinStack.push(vPrev)and cause problem.I asked the claude to reason about any potential infinite loop issue with the fix.
I didn't find any unit test for Triangulate in clipper2.
I ran
Triangulationexample and got this picture back.