hotfix: fix broken imports and add workflow to verify source code

.github/workflows/deno-format.yml

@@ -0,0 +1,38 @@
+name: deno-veify
+
+on:
+  pull_request:
+    types: [opened, synchronize]
+
+permissions:
+  contents: read
+
+jobs:
+  format:
+    permissions:
+      contents: write
+      pull-requests: write
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: setup deno
+        uses: denoland/setup-deno@v1
+
+      - name: auto-format code
+        run: deno fmt
+
+      - name: check for file changes
+        id: git_status
+        run: |
+          echo "::set-output name=status::$(git status -s)"
+
+      - name: create pull request with formatting corrections
+        if: ${{contains(steps.git_status.outputs.status, ' ')}}
+        uses: stefanzweifel/git-auto-commit-action@v5
+        with:
+          commit_message: "chore(automation): auto format code using deno fmt"
+          commit_options: '--no-verify --signoff'
+          file_pattern: '*.ts'
+          repository: .

.github/workflows/deno-test.yml

@@ -18,7 +18,7 @@ permissions:
   contents: read
 
 jobs:
-  lint-test:
+  unit-test:
     runs-on: ubuntu-latest
 
     steps:
@@ -33,8 +33,5 @@ jobs:
           cp .env.defaults .env
           rm deno.lock
 
-      - name: Run linter
-        run: deno lint
-
       - name: Run tests
-        run: deno test -A
+        run: deno task test

.github/workflows/deno-verify.yml

@@ -1,17 +1,16 @@
-name: deno-veify
+name: deno-verify
 
 on:
-  pull_request:
-    types: [opened, synchronize]
+  push: 
+    branches:
+      - dev
+      - main
 
 permissions:
   contents: read
 
 jobs:
-  format:
-    permissions:
-      contents: write
-      pull-requests: write
+  verify:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
@@ -20,19 +19,8 @@ jobs:
       - name: setup deno
         uses: denoland/setup-deno@v1
 
-      - name: auto-format code
-        run: deno fmt
-
-      - name: check for file changes
-        id: git_status
-        run: |
-          echo "::set-output name=status::$(git status -s)"
+      - name: Run deno linter
+        run: deno lint
 
-      - name: create pull request with formatting corrections
-        if: ${{contains(steps.git_status.outputs.status, ' ')}}
-        uses: stefanzweifel/git-auto-commit-action@v5
-        with:
-          commit_message: "chore(refactor): auto format"
-          commit_options: '--no-verify --signoff'
-          file_pattern: '*.ts'
-          repository: .
+      - name: Run deno checks
+        run: deno task check

deno.json

@@ -18,7 +18,8 @@
     "proseWrap": "preserve"
   },
   "tasks": {
+    "check": "deno check src/index.ts",
     "test": "deno test --allow-read --allow-env --allow-net",
-    "server": "deno run --allow-read --allow-env --allow-net --allow-sys ./src/index.ts"
+    "start": "deno run --allow-read --allow-env --allow-net --allow-sys ./src/index.ts"
   }
 }

src/config/local/source.ts

@@ -1,14 +1,14 @@
-import { Collection } from 'npm/mongodb';
+import { Collection, WithId } from 'npm/mongodb';
 import { logger } from '../../common/core/logger.ts';
 import { ConfigDocument } from './types.d.ts';
-import { EntityWithId, Optional } from '../../common/mongo/types.d.ts';
+import { Optional } from '../../common/mongo/types.d.ts';
 
 export class LocalSource {
   constructor(
     private readonly collection?: Collection<ConfigDocument>,
   ) {}
 
-  getConfig = async (): Promise<Optional<EntityWithId<ConfigDocument>>> => {
+  getConfig = async (): Promise<Optional<WithId<ConfigDocument>>> => {
     const config = await this.collection?.findOne()
       ?.catch((e) => {
         logger.error(

src/config/transformer/index.ts

@@ -1,16 +1,17 @@
+import { WithId } from 'npm/mongodb';
 import {
   getPlatformSource,
   isAnalyticsEnabled,
 } from '../../common/experiment/index.ts';
-import { EntityWithId, Optional } from '../../common/mongo/types.d.ts';
+import { Optional } from '../../common/mongo/types.d.ts';
 import { Transform } from '../../common/transformer/types.d.ts';
 import { Features } from '../../common/types/core.d.ts';
 import { ConfigDocument } from '../local/types.d.ts';
 import { ClientConfiguration } from './types.d.ts';
 
 export const transform: Transform<
   {
-    document: Optional<EntityWithId<ConfigDocument>>;
+    document: Optional<WithId<ConfigDocument>>;
     features: Features;
   },
   ClientConfiguration

src/news/local/source.ts

@@ -2,7 +2,7 @@ import { Collection, Filter, FindOptions, ObjectId, WithId } from 'npm/mongodb';
 import { logger } from '../../common/core/logger.ts';
 import { IPaging } from '../../common/types/paging.d.ts';
 import { IResponse } from '../../common/types/response.d.ts';
-import { fromEntity, toEntity } from '../mapper.ts';
+import { toDocument, toEntity } from '../mapper.ts';
 import { News } from '../types.d.ts';
 import { NewsDocument, NewsId } from './types.d.ts';
 import { between } from 'x/optic/profiler';
@@ -15,7 +15,7 @@ export default class LocalSource {
 
   saveAll = async (news: News[]) => {
     logger.mark('news_source_insertMany_start');
-    const entities = news.map(toEntity);
+    const entities = news.map(toDocument);
     await this.collection?.insertMany(entities)
       .then((document) => {
         logger.debug(
@@ -100,7 +100,7 @@ export default class LocalSource {
         );
       });
 
-    const items = documents?.map(fromEntity) ?? null;
+    const items = documents?.map(toEntity) ?? null;
     const count = items?.length ?? 0;
 
     let first, last: string | undefined = undefined;
@@ -146,7 +146,7 @@ export default class LocalSource {
       });
 
     if (document) {
-      const item = fromEntity(document);
+      const item = toEntity(document);
 
       return {
         data: item ?? null,

src/news/local/types.d.ts

@@ -2,7 +2,6 @@ import { Document } from 'npm/mongodb';
 import { EntityCursor } from '../../common/mongo/types.d.ts';
 
 export interface NewsDocument extends Document {
-  id: string;
   slug: string;
   title: string;
   author: string;

src/news/mapper.ts

@@ -2,7 +2,7 @@ import { News, NewsEntity } from './types.d.ts';
 import { NewsDocument } from './local/types.d.ts';
 import { OptionalId, WithId } from 'npm/mongodb';
 
-export const fromEntity = (data: WithId<NewsDocument>): NewsEntity => {
+export const toEntity = (data: WithId<NewsDocument>): NewsEntity => {
   return {
     id: data._id.toHexString(),
     slug: data.slug,
@@ -17,7 +17,7 @@ export const fromEntity = (data: WithId<NewsDocument>): NewsEntity => {
   };
 };
 
-export const toEntity = (data: News): OptionalId<NewsDocument> => {
+export const toDocument = (data: News): OptionalId<NewsDocument> => {
   return {
     slug: data.slug,
     title: data.title,