Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests of
fromJSON
function usesRectangle
function like this:These tests expect that
Rectangle
prototype has the methodgetArea
, butRectangle
can be implemented in other way andRectangle
tests allow to do it. For example, tests allow to implementRectangle
like this:In this example
Rectangle
prototype doesn't havegetArea
method. So, this case should be checked in tests.Why is it important? If you implement
Rectangle
in wrong way, you will get message thatfromJSON
function works incorrect, even if it is implemented in right way.