forked from playcanvas/engine
-
Notifications
You must be signed in to change notification settings - Fork 0
glTF scene support #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
godiagonal
wants to merge
166
commits into
old/master
Choose a base branch
from
feature/gltf-scene-support
base: old/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
166 commits
Select commit
Hold shift + click to select a range
0516568
Create the anim component
8791178
Unified the glb and anim clip paths in the binder
1331455
cleanup anim controller state transition code
5705a4b
anim controller cleanup
21ae4b5
support multiple animations in a single AnimState
fcaa9c0
spelling fix
b97f8ad
make the anim controller parameter driven and introduce transition ex…
46cc873
add transition offsets which allow for the entry time of destination …
76280c7
add a reset function to the anim controller and expose it in the anim…
bfb66d9
update anim clips after transitions and blending
314ee11
Update anim clip names to include state name
7d00286
syntax update
8a26728
use enums throughout the anim controller
c68bde5
Add transition interruption sources to the anim controller
17cd652
enclose logging in DEBUG conditionals
56e3d0d
Switch object copying to use object assign
86cad69
expose anim enums in the pc namespace
7b245f7
Update the anim property locator to escape forward slashes and cleanu…
6f5e31a
cache transitions when searching from and between states
f10f6c1
update anim controller parameters get/set methods
9d834cc
add jsdocs
2433108
anim component system cleanup
92f8e5b
anim component adjustments
726b98b
update anim component properties
d3cf7ca
remove unused code
94cabe9
remove functions to get active state name and progress
a5b8bfd
Merge branch 'master' into anim-component
2f8545c
update anim component to support morph targets
7f256a3
fix anim test
4257e1c
fix jsdocs
d0543a1
lint fix
a59c839
add a pause function & update enum types
ca75945
Update to anim component and controller code style
7247876
styling updates
0c9e3c4
fix breaking changes
89566a8
update typechecking
a69d95d
Merge branch 'master' into anim-component
3264612
code style changes
5304e54
animation clips can store multi component keyframe outputs
d94c1a3
Add an animatable properties engine example
a056978
update the animatable properties example
bf73691
update the anim component api
2016252
jsdocs fix
278f2c9
correctly handle transition iterruptions which return the controller …
e06b939
add a character animation example
1aa8828
record the previous transition states index in its name to uniquely i…
e55b9d4
performance update and comments for the anim controller
1afbd4a
add anim component layers to the anim component
ce25474
update examples
8898c79
jsdocs fix
ada6279
jsdocs fix
7883826
state graph multiple layers fix
655f08d
wip: test returning entity instead of model from parser
1476e77
feat(GlbParser): return pc.Entity instead of pc.Model as scene
5d6c787
refactor(GlbParser): remove now unused createModel method
3803bbd
feat(GlbParser): add support for glTF properties scene and scenes
df12ec6
refactor(GlbParser): remove unused code
e5f2cc2
fix(GlbParser): fix animation curve paths by using node names in pc.M…
36192ab
refactor(GlbParser): remove "model_" prefix from pc.Model root nodes
b387449
wip(GlbParser): automatically add animation components to entities in…
9a8e40d
fix: allow animation of entities without model components, e.g. group…
d82ebc8
fix(pc.Model): keep references to bone nodes outside the model when c…
8d98403
refactor(GlbParser): handle absence of scene node with null instead o…
69372f4
refactor(GlbParser): remove animationComponents from container data
288e2ef
fix(GlbParser): fix cleanup process for ContainerResource
3b3faad
refactor(ContainerResource): use Array.map instead of for loop to cre…
bdee645
refactor(GlbParser): propagate default material from ContainerHandler…
b039aff
chore(GlbParser): remove todo comment
bd5eb3f
fix(AnimationComponent): make it possible to use AnimationComponent o…
4a87dd5
chore(ContainerResource): update jsdoc documentation
3540283
addressed PR comments
855d05c
Merge remote-tracking branch 'ellt92/anim-component' into feature/new…
e976903
feat(GlbParser): use new pc.AnimComponent
9835700
refactor(GlbParser): refactor the way node locator paths are calculat…
a975095
fix(AnimComponentSystem): remove call to undefined function
ae76a07
refactor(ContainerResource): remove console.log
85de1af
refactor(GlbParser): add sanity check for nodeComponents in createMod…
5822254
fix(ContainerResource): make sure anim components are enabled by defa…
98e1318
chore(AnimComponent): fix jsdoc/typings
72c8a68
Merge branch 'master' into feature/gltf-scene-support
9b60ba2
1.28.0-rc.0
2e6ad0b
create a new animation update step in the component system, expose la…
44889fb
Merge branch 'master' into anim-component
14aae18
Merge remote-tracking branch 'ellt92/anim-component' into feature/glt…
456d9a8
fix(AnimComponent): make methods and properties public
da3dfaf
refactor(ContainerResource): use prop pc.AnimComponentLayer.states to…
4bdc4e5
anim component play state fix
23d7422
Merge branch 'master' into anim-component
8cddf52
PR comments
855ba30
test fix
3d16a3a
find enities using the findByPath function in the anim binder
becf669
handle null case for anim findAnimationLayer
5e832d5
updated the assignAnimation function
915b70d
pro comments
adcf1da
update anim resource names
451dcb9
flag animation udpates to any materials
ec5b99c
fix the anim controllers playable variable
e879b73
add a new baseLayer variable to the anim component and fix the stateG…
20f50e9
Merge branch 'master' into anim-component
60cd93c
fix merge issue
99f9c8b
change how the anim binder flags materials
62c396a
Merge branch 'master' into anim-component
0b35179
anim controller syntax change
69b6d5c
Merge remote-tracking branch 'upstream/anim-component' into feature/g…
0c19f10
fix(ContainerHandler): fix issue with baseUrl introduced in merge
13b5340
fix(GlbParser): prevent double asset prefixes in texture urls
506f436
fix(ContainerHandler): fix scenes unloading
0e668e9
Merge branch 'master' into feature/gltf-scene-support
c5c8524
fix(GlbParser): fix so that slashes in node names don't interfere wit…
3a96424
ci: fix ci error
eac2d56
fix: fix lint errors
904dec0
Merge branch 'master' into feature/gltf-scene-support
ccca2ec
refactor(GlbParser): change argument order of parseAsync
ae8475d
Merge remote-tracking branch 'upstream/master' into feature/gltf-scen…
3282a02
Merge branch 'master' into feature/gltf-scene-support
d0a8988
fix: make AnimTrack public
d1678ca
fix: typings for AnimTrack.name and AnimComponentLayer.playing
deaf615
fix: add implementation for AnimController.playing
32ef6fd
feat(AnimComponent): make it possible to not loop animations by provi…
1105243
feat(GlbParser): make it possible to not loop animations (WIP)
4a08137
feat: make AnimComponent methods and props public
86e8d40
feat(ContainerResource): return node-animation mapping instead of ass…
9340980
refactor(GlbParser): remove unnecessary graph node per mesh instance …
88d2791
feat(ContainerResource): return animation index instead of asset in n…
41fb0bd
chore: revert AnimComponent jsdoc
a335f72
Merge branch 'master' into feature/gltf-scene-support
f238026
feat: re-apply changes to container resource that were lost in upstre…
bae3188
feat: re-apply changes to GLB parser that were lost in upstream merge
57e6f96
1.30.0-rc.0
558ecf5
fix(GlbParser): fix broken reference to Entity
6d9e978
Revert "1.30.0-rc.0"
1bd4781
feat(GlbParser): return model per glTF mesh as well as model per node
7b47425
refactor(ContainerResource): add _ prefix to nodeModels to signal tha…
b9e35c2
refactor(GlbParser): clone node models instead of running createModel…
2a18395
fix(GlbParser): fix typo
9330c09
feat(ContainerResource): include nodes in result since it may be rele…
d4a0e5a
chore(ContainerResource): add note about _nodeModels
c0fddb2
feat(GlbParser): add support for glTF cameras
2275965
feat(GlbParser): add support for KHR_lights_punctual
c407939
Merge branch 'master' into feature/gltf-scene-support
de9a563
feat(GlbParser): optimize reusing skin instances as implemented in ht…
546d138
refactor(GlbParser): simplify creation of nodeModels by removing need…
59510bb
refactor(GlbParser): replace nodeComponents with nodeAnimations
a23b3be
chore(ContainerResource): remove unnecessary comments
1c70dbf
feat(ContainerResource): include both images and textures in container
b057e3a
chore(ContainerResource): update jsdoc
a2bcd8b
Merge branch 'master' into feature/gltf-scene-support
4820136
Merge branch 'master' into feature/gltf-scene-support
54b0fdc
Merge branch 'master' into feature/gltf-scene-support
c944b67
refactor(AnimState): remove duplicate property "loop"
0e6f465
Merge branch 'master' into feature/gltf-scene-support
eb853e4
fix(GlbParser): fix incorrect reference to camera callbacks
f5ae9b2
refactor(GlbParser): use Number.POSITIVE_INFINITY for infinite light …
7a29662
refactor(GlbParser): remove use of Object.assign for camera props
a792880
refactor(GlbParser): rename variable
29a8d99
feat(GlbParser): add support for light extensions
ecccb5f
refactor(ContainerResource): rename nodeAnimations to animationIndice…
4505a72
refactor(GlbParser): handle null AssetRegistry prefix when loading te…
9f90919
Merge branch 'master' into feature/gltf-scene-support
ddf1069
fix(ContainerResource): fix merge issue
4a513b8
fix(GlbParser): fix typo causing bugs with options.texture.postprocess
cd76697
refactor(GlbParser): replace use of const with var
1a81d8f
refactor(GlbParser): remove use of array spread syntax
334318b
refactor(GlbParser): replace use of const with var
71d8e56
Merge branch 'master' into feature/gltf-scene-support
455f9eb
fix(ContainerHandler): add missing null check for container
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.