Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[bug]: Home button link not working from cart page #132 #178

Closed
wants to merge 4 commits into from

Conversation

Vaibhav-Kumar10
Copy link
Contributor

@Vaibhav-Kumar10 Vaibhav-Kumar10 commented Oct 4, 2024

Description

I have updated the link to home page which was not working on cart page, when clicking the home button.

Related Issues

Type of PR

  • ()

Screenshots / videos (if applicable)

image

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Updated the header-container class of cart.html page to link correctly to home page.
The link to home page from cart page is corrected.
header_container class has been updated.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Vaibhav-Kumar10! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 20e92b3
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/66ffe88409c7a20008289554
😎 Deploy Preview https://deploy-preview-178--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51 Anjaliavv51 closed this Oct 4, 2024
@Vaibhav-Kumar10
Copy link
Contributor Author

@Anjaliavv51 please help me to modify my PR so that it can be merged

@shreyash3087
Copy link

@Anjaliavv51 Hey,can you explain the reason to close hir PR to him,also change your labels to gssoc-ext from GSSOCEXTD otherwise the pr's from your repo wont be counted towards GSSoC Extd Leaderboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Home button link not working from cart page
3 participants