Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature Request]: Want to improve design of cart page #42

Merged
merged 10 commits into from
Oct 2, 2024

Conversation

Mr-DK07
Copy link
Contributor

@Mr-DK07 Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 I have changes the UI of the Cart page. Just take a look. If you want any improvement, just tell me.

Before: -
Screenshot 2024-10-02 100838

After: -
Screenshot 2024-10-02 100852

If you are merging don't forget (Level) it.

#26

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
retro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:29am
retro.throwback.to.the.vintage.era ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:29am
retrovintage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:29am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Mr-DK07! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Anjaliavv51
Copy link
Owner

@Mr-DK07 please make sure colors matches the website!

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 It is updated

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 It is updated

i canit see any commits though?

@Anjaliavv51
Copy link
Owner

@Mr-DK07 ur changes are not updated pls check the below screenshoot.

image

background color of heading are updated.
Copy link

vercel bot commented Oct 2, 2024

Deployment failed with the following error:

Resource is limited - try again in 5 hours (more than 100, code: "api-deployments-free-per-day").

@Anjaliavv51
Copy link
Owner

@Mr-DK07 please change the color and also resolve conflicts.

Update settings.json
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 7c9daa2
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/66fd96bd0470350008594075
😎 Deploy Preview https://deploy-preview-42--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

color changes
@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 okay

Update settings.json
@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

Screenshot 2024-10-02 192424

@Anjaliavv51 Is it good?

@Anjaliavv51
Copy link
Owner

Screenshot 2024-10-02 192424

@Anjaliavv51 Is it good?

i appreciat eur afforts , but i am not satisfied with those colors

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 can you explain, what exactly do you want?

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 can you explain, what exactly do you want?

make sure the colors matches the background

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 can you explain, what exactly do you want?

orelse set the color as transparent.

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 Check these screenshot and tell me which one do you prefer for your website.

Screenshot 2024-10-02 201350

Screenshot 2024-10-02 201607

Screenshot 2024-10-02 202035

@Anjaliavv51
Copy link
Owner

@Mr-DK07 3

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Mr-DK07 3

@Anjaliavv51 Okay I am going to commit the changes, make sure to add level also like (level 1, level 2, level 3) before merging.

Update cart.html
@Anjaliavv51
Copy link
Owner

@Mr-DK07 3

@Anjaliavv51 Okay I am going to commit the changes, make sure to add level also like (level 1, level 2, level 3) before merging.

I will @Mr-DK07 don't worry.

@Anjaliavv51 Anjaliavv51 changed the title #26 [feature Request]: Want to improve design of cart page [feature Request]: Want to improve design of cart page Oct 2, 2024
@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 are you going to merge it.
I have committed the changes.

@Anjaliavv51
Copy link
Owner

@Mr-DK07

image

overlap, please check it.

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 Not understanding, are you talking about order now button

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 Not understanding, are you talking about order now button

Yes and also in footer

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 check this out.
Screenshot 2024-10-02 232615

@Anjaliavv51 Anjaliavv51 added good first issue Good for newcomers Level 2 labels Oct 2, 2024
@Anjaliavv51
Copy link
Owner

@Mr-DK07 pls join the meet
https://meet.google.com/ntw-xiho-tvg

@Mr-DK07
Copy link
Contributor Author

Mr-DK07 commented Oct 2, 2024

@Anjaliavv51 just check it.

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 just check it.

gimme a min

@Anjaliavv51 Anjaliavv51 merged commit d7a322a into Anjaliavv51:main Oct 2, 2024
6 checks passed
Copy link

github-actions bot commented Oct 2, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@Anjaliavv51
Copy link
Owner

@Mr-DK07 keep contributing to our repo thank you!

2004shweta pushed a commit to 2004shweta/Retro that referenced this pull request Oct 15, 2024
Issue Anjaliavv51#41 Resolved warnings in Home and Login components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants