-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature Request]: Want to improve design of cart page #42
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Mr-DK07! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
@Mr-DK07 please make sure colors matches the website! |
@Anjaliavv51 It is updated |
i canit see any commits though? |
@Mr-DK07 ur changes are not updated pls check the below screenshoot. |
background color of heading are updated.
Deployment failed with the following error:
|
@Mr-DK07 please change the color and also resolve conflicts. |
Update settings.json
✅ Deploy Preview for rococo-mooncake-0d89f7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
color changes
@Anjaliavv51 okay |
Update settings.json
@Anjaliavv51 Is it good? |
i appreciat eur afforts , but i am not satisfied with those colors |
@Anjaliavv51 can you explain, what exactly do you want? |
make sure the colors matches the background |
orelse set the color as transparent. |
@Anjaliavv51 Check these screenshot and tell me which one do you prefer for your website. |
@Mr-DK07 3 |
@Anjaliavv51 Okay I am going to commit the changes, make sure to add level also like (level 1, level 2, level 3) before merging. |
Update cart.html
I will @Mr-DK07 don't worry. |
@Anjaliavv51 are you going to merge it. |
overlap, please check it. |
@Anjaliavv51 Not understanding, are you talking about order now button |
Yes and also in footer |
@Anjaliavv51 check this out. |
@Mr-DK07 pls join the meet |
@Anjaliavv51 just check it. |
gimme a min |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
@Mr-DK07 keep contributing to our repo thank you! |
Issue Anjaliavv51#41 Resolved warnings in Home and Login components
@Anjaliavv51 I have changes the UI of the Cart page. Just take a look. If you want any improvement, just tell me.
Before: -
After: -
If you are merging don't forget (Level) it.
#26