Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[feature Request]: Enable PWA for the site #704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohammedanaf
Copy link

@mohammedanaf mohammedanaf commented Oct 22, 2024

Description

The website is now a Progressive Web Application where users can install it as a desktop or mobile application and access it easily. Not only that; it also provides offline access by pre-downloading assets mentioned in service-worker.js for faster reloading.

Related Issues

Type of PR

  • (feature Request)

Screenshots / videos (if applicable)

https://www.loom.com/share/635a2d108ff7426a9fb0eb06a61371cc?sid=c520bb83-74c0-4950-8749-5a80a04f3f37

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

I have modified index.html with an inline comment to link manifest.json. I have also added two other files named manifest.json and service-worker.js for enabling PWA. I have also added a service worker script in index.html at the bottom with an inline comment to detect service-worker.js file in the root of the folder. I have also resized favicons to 192x192 and 512x512 format for app icon in different screen sizes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @mohammedanaf! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 8a0b9ef
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/6717eb9e5df5e700081c2310
😎 Deploy Preview https://deploy-preview-704--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mohammedanaf mohammedanaf marked this pull request as ready for review October 23, 2024 02:10
@mohammedanaf
Copy link
Author

@Anjaliavv51 the site is pwa-enabled and this PR is awaiting your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Enable PWA for the site
1 participant