Fix padding in mqttapi::make_mqtt_pkt#136
Open
mtoner23 wants to merge 1 commit intoAnkermgmt:masterfrom
Open
Conversation
Contributor
|
@mtoner23 so are you saying that even with this code you are unable to send prints to the printer from Prusa when having |
Contributor
Author
|
Sorry bad phrasing. With this code I can send prints via prusaslicer to the webserver. I was trying to send manual gcode for something else which exposed this issue in the constructor. |
|
Here is an example traceback without this change: This is an example result with the change in place: |
|
This is also fixed in PR #145 in a way which supports both Ankermake M5 and M5C printers, see d9af577 . You can try the fork at https://github.com/anselor/ankermake-m5-protocol/tree/exiles which integrates this PR and a number of other pending ones. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried sending gcode over mqtt and this errored out. even with this fix the printer doesnt respond to the gcode but maybe thats my user error. since we have no clue what this field does i think its fine to do what we were doing before the previous fix; send all zeros.