Merge pull request #3 from warquys/ReviewNinjecet

Review ninjecet

Neuron.Core/NeuronImpl.cs

@@ -14,6 +14,7 @@
 using Neuron.Core.Plugins;
 using Neuron.Core.Scheduling;
 using Ninject;
+using Ninject.Planning.Bindings.Resolvers;
 
 namespace Neuron.Core
 {
@@ -36,7 +37,14 @@ public override void Start()
             }
             Kernel.BindSimple<NeuronBase>(this);
             Kernel.BindSimple(Configuration);
-
+
+            if (!Platform.Configuration.NinjectGenerateDefaultBindings)
+            {
+                Kernel.Components.Remove<IMissingBindingResolver, SelfBindingResolver>();
+                Kernel.Components.Add<IMissingBindingResolver, NullableBindingResolver>();
+                Kernel.Settings.AllowNullInjection = true;
+            }
+
             if (Platform.Configuration.OverrideConsoleEncoding) Console.OutputEncoding = Encoding.UTF8;
             if (Platform.Configuration.FileIo)
             {
@@ -149,7 +157,7 @@ public void LoadIoPlugins()
                 }
             }
         }
-        
+
         public override void Stop()
         {
             Kernel.Get<PluginManager>().UnloadAll();

Neuron.Core/NullableBindingResolver.cs

@@ -0,0 +1,76 @@
+using Ninject.Activation.Providers;
+using Ninject.Activation;
+using Ninject.Components;
+using Ninject.Infrastructure;
+using Ninject.Planning.Bindings;
+using Ninject.Planning.Bindings.Resolvers;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace Neuron.Core;
+
+public class NullableBindingResolver : NinjectComponent, IMissingBindingResolver, INinjectComponent, IDisposable
+{
+    public class NullProvider : IProvider
+    {
+        public NullProvider(Type prototype)
+        {
+            Type = prototype;
+        }
+
+        public Type Type { get; private set; }
+
+        public object Create(IContext context) => null;
+    }
+
+    /// <summary>
+    /// Returns any bindings from the specified collection that match the specified service.
+    /// </summary>
+    /// <param name="bindings">
+    /// The multimap of all registered bindings.
+    /// </param>
+    /// <param name="request">
+    /// The series of matching bindings.
+    /// </param>
+    /// <returns>
+    /// The series of matching bindings.
+    /// </returns>
+    public IEnumerable<IBinding> Resolve(Multimap<Type, IBinding> bindings, IRequest request)
+    {
+        var service = request.Service;
+        if (!TypeIsSelfBindable(service))
+        {
+            return Enumerable.Empty<IBinding>();
+        }
+
+        var provider = new NullProvider(service);
+
+        return new Binding[1]
+        {
+            new Binding(service)
+            {
+                ProviderCallback = (IContext _) => provider
+            }
+        };
+    }
+
+    /// <summary>
+    /// Returns a value indicating whether the specified service is self-bindable.
+    /// </summary>
+    /// <param name="service">
+    /// The service.
+    /// </param>
+    /// <returns>
+    /// True if the type is self-bindable; otherwise false.
+    /// </returns>
+    protected virtual bool TypeIsSelfBindable(Type service)
+    {
+        if (!service.IsInterface && !service.IsAbstract && !service.IsValueType && service != typeof(string))
+        {
+            return !service.ContainsGenericParameters;
+        }
+
+        return false;
+    }
+}

Neuron.Core/Platform/PlatformConfiguration.cs

@@ -26,6 +26,13 @@ public class PlatformConfiguration
     /// </summary>
     public bool UseGlobals { get; set; } = true;
 
+    /// <summary>
+    /// By default Ninject generate a default binding when no binding is found.
+    /// This default binding create a new inistance of the requested type.
+    /// If <see langword="false"/>, Ninject will return <see langword="null"/> when the type is requested.
+    /// </summary>
+    public bool NinjectGenerateDefaultBindings { get; set; } = true;
+
     /// <summary>
     /// Also writes events to this consumer instead of only the console and possibly a logfile
     /// </summary>

Neuron.Tests.Commands/Neuron.Tests.Commands.csproj

@@ -14,6 +14,10 @@
 
     <ItemGroup>
         <PackageReference Include="xunit" Version="2.1.0" />
+        <PackageReference Include="xunit.runner.visualstudio" Version="2.8.1">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
     </ItemGroup>
 
     <ItemGroup>

Neuron.Tests.Configs/Neuron.Tests.Configs.csproj

@@ -19,6 +19,10 @@
     <ItemGroup>
         <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="6.0.1" />
         <PackageReference Include="xunit" Version="2.1.0" />
+        <PackageReference Include="xunit.runner.visualstudio" Version="2.8.1">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
     </ItemGroup>
 
     <ItemGroup>

Neuron.Tests.Core/Neuron.Tests.Core.csproj

@@ -18,6 +18,10 @@
 
     <ItemGroup>
         <PackageReference Include="xunit" Version="2.1.0" />
+        <PackageReference Include="xunit.runner.visualstudio" Version="2.8.1">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
     </ItemGroup>
 
     <ItemGroup>