Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeAlias declaration for Float64Array in matrices.py #125

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Oct 23, 2024

Correct the TypeAlias declaration for Float64Array to ensure proper type hinting in the code.

Summary by Sourcery

Bug Fixes:

  • Correct the TypeAlias declaration for Float64Array to ensure proper type hinting in matrices.py.

Copy link

semanticdiff-com bot commented Oct 23, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 22% smaller than the GitHub diff.

Filename Status
✔️ tanabesugano/matrices.py 21.88% smaller

Copy link

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This pull request corrects the TypeAlias declaration for Float64Array in the matrices.py file, improving type hinting for the codebase.

Updated class diagram for Float64Array TypeAlias

classDiagram
    class Float64Array {
        <<TypeAlias>>
        NDArray[np.float64]
    }
    note for Float64Array "Corrected TypeAlias declaration for proper type hinting"
Loading

File-Level Changes

Change Details Files
Corrected the TypeAlias declaration for Float64Array
  • Removed commented-out line with incorrect TypeAlias declaration
  • Replaced direct assignment with proper TypeAlias syntax
  • Ensured Float64Array is correctly defined as NDArray[np.float64]
tanabesugano/matrices.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Anselmoo Anselmoo merged commit 220b1da into master Oct 23, 2024
10 checks passed
@Anselmoo Anselmoo deleted the feature/TypeAlias branch October 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant