proper conditional checks (#82)

* proper check of a boolean, handling all cases (like undefined var and --extra-vars mesos_apt_pin_priority=false|true cases) * fix when check to properly handle --extra-vars mesos_agent_meta_cleanup=false
AnsibleShipyard · Feb 19, 2018 · 467d9ab · 467d9ab
1 parent 27b7829
commit 467d9ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/handlers/main.yml b/handlers/main.yml
@@ -9,7 +9,7 @@
   file: path="{{mesos_work_dir}}/meta/slaves/latest" state=absent
   when:
    - mesos_install_mode == "slave" or mesos_install_mode == "master-slave"
-   - mesos_agent_meta_cleanup
+   - mesos_agent_meta_cleanup | bool
 
 # i.e. upgrade mesos, templates stay the same...
 - name: Restart mesos-master

diff --git a/tasks/Debian.yml b/tasks/Debian.yml
@@ -9,7 +9,7 @@
   template:
     src: mesos.pref.j2
     dest: /etc/apt/preferences.d/mesos.pref
-  when: mesos_apt_pin_priority is defined
+  when: mesos_apt_pin_priority | default(false) | bool
 
 - name: Install Debian OS packages
   apt: pkg={{ item }} state=present update_cache=yes cache_valid_time=3600