Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring that only strings are added to the collection and queries #115

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Ensuring that only strings are added to the collection and queries #115

merged 4 commits into from
Feb 7, 2024

Conversation

Gautam-Rajeev
Copy link
Contributor

Fixing issue described #114

@Gautam-Rajeev
Update RAGTrainer.py
18a0cf9 
Fixing issue described AnswerDotAI#114
@Gautam-Rajeev Gautam-Rajeev changed the title Update RAGTrainer.py Ensuring that only strings are added to the collection and queries Feb 6, 2024
@Gautam-Rajeev
Copy link
Contributor Author

@bclavie @Anmol6 / @anirudhdharmarajan tiny PR here to clean up verifying collection and queries while creating triplets.
Wasn't able to run it on base code as shown here but works with these fixes - #114

@bclavie
Copy link
Collaborator

bclavie commented Feb 7, 2024

Thank you! This looks good to me, except one thing (I'll change it myself): I think we should error out if there are non-strings in the x[0] items, as it's likely indicative of data issues if queries aren't passed as strings!

@bclavie bclavie enabled auto-merge (squash) February 7, 2024 18:56
@bclavie bclavie linked an issue Feb 7, 2024 that may be closed by this pull request
'Prepare training data' facing unhashable type error #114
Closed
@bclavie bclavie merged commit e2343e1 into AnswerDotAI:main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclavie bclavie bclavie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Prepare training data' facing unhashable type error
2 participants
@Gautam-Rajeev @bclavie