-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for locate command on new versions from 1.18 to 1.20 #318
Conversation
Converted to draft. Nether and end doesn't work... I totally forgot about dimensions. Only started playing minecraft. Haven't even beat the end yet |
Issues with dimension should be fixed. Edit: Sorry for the force pushes. Needed to re-trigger the workflow because I fucked up my maven repository |
Tested on MacOS and Windows VM. It works. Should be fine to merge. |
…nghold search. Also remember to actually use cubiomesVersion rather than hard coding MC_1_20
I rebased and somehow that caused the CI to fail. /home/runner/work/meteor-rejects/meteor-rejects/src/main/java/anticope/rejects/modules/OreSim.java:215: error: chunk has private access in ChunkDataEvent
doMathOnChunk(event.chunk); OreSim.java isn't even changed. A bit confused |
|
How about
I can't find any references online |
I'm guessing this means I can just delete the line |
yes |
Description
Replace mc_biome_java on versions greater than or equal to 1.18
Related Issue
#316
Motivation and Context
I want the locate command to work
How Has This Been Tested?
Tested on MacOS, Windows, and Linux. Pretty much everything works.
It still works on older versions since we reuse old WorldGenUtils below 1.18.
Screenshots (if appropriate):
Types of changes