Update grub-btrfsd submenu creation #289
Conversation
fix grub.cfg path in grub submenu creation
| @@ -206,7 +206,7 @@ setup() { | |||
| create_grub_menu() { | |||
| # create the grub submenu of the whole grub menu, depending on wether the submenu already exists | |||
| # and gives feedback if it worked | |||
| if grep "snapshots-btrfs" "{grub_directory}/grub.cfg"; then | |||
| if grep "snapshots-btrfs" "${GRUB_BTRFS_GRUB_DIRNAME:-/boot/grub}"/grub.cfg; then | |||
There was a problem hiding this comment.
I am not sure how this solves it. The grub_directory variable should already be set to this:
Line 93 in ade5a91
|
Thanks for your PR, good call, because normally you don't notice. // I'm gonna think about why I have done this a bit, then merge. |
|
This is what was going on in the 4.12 version: |
|
Yes, that doesn't work anymore since we do not always have |
fix grub.cfg path in grub submenu creation. Addresses issue #288: grub-btrfsd submenu creation fails and the entire grub menu is recreated causing a conflict with "timeshift-autosnap" set to update grub as default.