Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Port selection field. #2514

Merged
merged 13 commits into from
Feb 9, 2025
Merged

[QoL] Port selection field. #2514

merged 13 commits into from
Feb 9, 2025

Conversation

antsif-a
Copy link
Contributor

@antsif-a antsif-a commented Sep 7, 2020

It looks like this:
host-valid

When port is invalid:
host-invalid
The valid port is saved in the game settings and uses as default for the next game.

  • Help message refactor.

Contributed by @zethnest.

@antsif-a antsif-a marked this pull request as ready for review September 7, 2020 18:17
@antsif-a antsif-a closed this Sep 23, 2020
@deltanedas
Copy link
Contributor

why close

@Remint32
Copy link
Contributor

reopen please

@Anuken
Copy link
Owner

Anuken commented Sep 24, 2020

It's better to leave this unmerged for now, because local server discovery breaks when the port used is non-default.

@antsif-a
Copy link
Contributor Author

What if I just want to host the game on a different port, without even displaying it in the local server list?

@antsif-a antsif-a reopened this Sep 24, 2020
@Anuken
Copy link
Owner

Anuken commented Sep 24, 2020

Right now, you can't.

@antsif-a
Copy link
Contributor Author

Yes I know. This is why I am making this pull.

@Anuken
Copy link
Owner

Anuken commented Sep 24, 2020

I'm saying you can't not display it on the local server list.

@antsif-a antsif-a marked this pull request as draft December 25, 2020 00:55
@zatnas
Copy link
Contributor

zatnas commented Dec 31, 2020

If a host with a different port is found, should it not be displayed or should it be displayed? Reason?

I know currently Mindustry is able to discover hosts with any port. I am trying to mitigate the problem where local server discovery breaks when the port used is non-default

@Anuken
Copy link
Owner

Anuken commented Dec 31, 2020

If a host with a different port is found, should it not be displayed or should it be displayed? Reason?

It doesn't matter. Either one works.

Servers can be discovered on any port, but the connection port is never passed from the discovery system to the client. Clients will see non-default-port servers on their list, but will fail to connect to them.

@zatnas
Copy link
Contributor

zatnas commented Jan 3, 2021

@summetdev Merge conflicts and make ready for review?

@antsif-a antsif-a marked this pull request as ready for review January 3, 2021 11:54
@deltanedas
Copy link
Contributor

mindustry

@Anuken
Copy link
Owner

Anuken commented Feb 9, 2025

fake

@Anuken Anuken merged commit 03c3414 into Anuken:master Feb 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants