-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QoL] Port selection field. #2514
Conversation
why close |
reopen please |
It's better to leave this unmerged for now, because local server discovery breaks when the port used is non-default. |
What if I just want to host the game on a different port, without even displaying it in the local server list? |
Right now, you can't. |
Yes I know. This is why I am making this pull. |
I'm saying you can't not display it on the local server list. |
If a host with a different port is found, should it not be displayed or should it be displayed? Reason? I know currently Mindustry is able to discover hosts with any port. I am trying to mitigate the problem where |
It doesn't matter. Either one works. Servers can be discovered on any port, but the connection port is never passed from the discovery system to the client. Clients will see non-default-port servers on their list, but will fail to connect to them. |
@summetdev Merge conflicts and make ready for review? |
mindustry |
fake |
It looks like this:
![host-valid](https://user-images.githubusercontent.com/55251897/92409168-538e5e80-f148-11ea-85cb-4ebc306eaf1e.png)
When port is invalid:
![host-invalid](https://user-images.githubusercontent.com/55251897/92409186-630da780-f148-11ea-80ed-5ee5138b2857.png)
The valid port is saved in the game settings and uses as default for the next game.
Contributed by @zethnest.