Minor visual things #8422
Closed
Minor visual things #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added mining beam weapons similar to building beam weapons. 2023_03_24_12_06_50_javaw.mp4 |
Anuken
reviewed
Mar 26, 2023
core/src/mindustry/world/blocks/defense/turrets/LaserTurret.java
Outdated
Show resolved
Hide resolved
So that really bad delta time won't let the bullet despawn when it shouldn't.
- Trail fade is not scaled properly - Trail doesn't stay centered on the engine while shrinking - Trail is not scaled properly while falling
...would be nice if effects had a second float parameter for cases like this where it's just the same effect on a different layer. Like how bullets have an fdata.
|
|
Apply to trail fade
|
...what |
|
oh jeez I'm going to need to look through what's changed |
|
Should probably split into smaller PRs. |
|
Yea, I'll just close this mess. |
This was referenced Feb 9, 2025
Merged
|
Do I bother re-implementing effect fdata in another pr? |
|
And is continuous laser growtime necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
growTimeforContinuousLaserBulletTypes.2023_03_23_20_24_12_javaw.mp4
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
(Hey @bluewolf3682, now's your chance to complain about other small visual issues.)