Markers update #9348
Closed
Markers update #9348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype and id arguments for instruction consistency
…ercontrol instructions cleanup, fix renderer's draw color breaking after drawing markers
|
And again i found accidental autoformatting issues (probably happened before i unbinded file reformat in intellij idea) |
|
Finishing this tomorrow |
Anuken
reviewed
Dec 4, 2023
| @@ -157,18 +157,29 @@ public boolean bool(int index){ | |||
| return v.isobj ? v.objval != null : Math.abs(v.numval) >= 0.00001; | |||
| } | |||
|
|
|||
| @Nullable | |||
| public double num(int index, boolean nullToNan){ | |||
There was a problem hiding this comment.
To avoid slowing down the common case (not nullToNan), I think this should be a separate method (e.g. numOrNan)
|
Fixed reformatting/splitted variable getter method in LExec |
|
Ok don't ask any questions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything here should be done, but i don't have time to fill PR description (it will just probably appear tomorrow). If lack of description is fine, here it is.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: